Merged
Conversation
silvenac
approved these changes
Jan 2, 2026
AppendStrID was copied out of a system that only used UUIDs for string IDs, so we could make the assumption that IDs would be shorter than 127-bytes. This is not true generally, but apparently while copying the function, we forgot to re-evaluate the assumptions in the code. (even when stated in the comments) Fortunately, `encoding/binary.AppendUvarint` will grow the buffer if necessary, so this is a performance bug, not a correctness bug.
dfinkel
force-pushed
the
cachekey_fix_id_length_assumption
branch
from
a85d874 to
aaf5a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppendStrID was copied out of a system that only used UUIDs for string
IDs, so we could make the assumption that IDs would be shorter than
127-bytes. This is not true generally, but apparently while copying the
function, we forgot to re-evaluate the assumptions in the code. (even
when stated in the comments)
Fortunately,
encoding/binary.AppendUvarintwill grow the buffer ifnecessary, so this is a performance bug, not a correctness bug.