fix(shard): ensure correct evicted entries count #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When evicting all entries (100% eviction), store the count before clearing the map. Previously we were reporting the length of an empty map, resulting in incorrect eviction metrics. The fix ensures accurate reporting of mass evictions for monitoring cache behavior. Added test coverage to verify both the evicted entries count and forced eviction events are correct. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
Owner
|
@thevilledev Thank you so much for this contribution and I really appreciate that you updated the test |
Contributor
Author
|
No problem, happy to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When evicting all entries (100% eviction), store the count before clearing the map. Previously we were reporting the length of an empty map, resulting in incorrect eviction metrics. The fix ensures accurate reporting of mass evictions for monitoring cache behavior.
Added test coverage to verify both the evicted entries count and forced eviction events are correct.