Conversation
Member
|
Yes, please add tests. Probably want at least 3 tests:
And then throw if depth=-1 or anything less than zero perhaps? |
Contributor
Author
|
@styfle I added the throw for negative depth, and added unit tests for depth from 0 to 3. |
styfle
reviewed
Jan 14, 2026
styfle
reviewed
Jan 15, 2026
styfle
reviewed
Jan 15, 2026
Member
styfle
left a comment
There was a problem hiding this comment.
Readme needs to be updated too to mention the new option (and the caveat it can't be less than 0)
Co-authored-by: Steven <steven@ceriously.com>
Contributor
Author
Done 👍 |
styfle
reviewed
Jan 21, 2026
styfle
reviewed
Jan 21, 2026
styfle
reviewed
Jan 21, 2026
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Steven <steven@ceriously.com>
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analyzefunction andJobclass #559