Skip to content

feat: add depth option#561

Merged
styfle merged 8 commits intovercel:mainfrom
magne4000:magne4000/depth
Jan 21, 2026
Merged

feat: add depth option#561
styfle merged 8 commits intovercel:mainfrom
magne4000:magne4000/depth

Conversation

@magne4000
Copy link
Contributor

@magne4000 magne4000 commented Jan 12, 2026

@magne4000 magne4000 requested review from a team, icyJoseph, ijjk and styfle as code owners January 12, 2026 10:43
@styfle
Copy link
Member

styfle commented Jan 13, 2026

Yes, please add tests. Probably want at least 3 tests:

  • depth=0
  • depth=1
  • depth=2

And then throw if depth=-1 or anything less than zero perhaps?

@magne4000
Copy link
Contributor Author

magne4000 commented Jan 14, 2026

@styfle I added the throw for negative depth, and added unit tests for depth from 0 to 3.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme needs to be updated too to mention the new option (and the caveat it can't be less than 0)

magne4000 and others added 2 commits January 15, 2026 16:16
@magne4000
Copy link
Contributor Author

Readme needs to be updated too to mention the new option (and the caveat it can't be less than 0)

Done 👍

@magne4000 magne4000 requested a review from styfle January 20, 2026 00:40
magne4000 and others added 2 commits January 21, 2026 19:04
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Steven <steven@ceriously.com>
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! 🎉

@styfle styfle enabled auto-merge (squash) January 21, 2026 18:22
@styfle styfle disabled auto-merge January 21, 2026 18:22
@styfle styfle enabled auto-merge (squash) January 21, 2026 18:22
@styfle styfle merged commit 34f1ec7 into vercel:main Jan 21, 2026
14 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@magne4000 magne4000 deleted the magne4000/depth branch January 21, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export analyze function and Job class

2 participants