Fix: Add custom config 1 and 2 to mobile view. #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Pleeeeeeease can we get this added? It's a dummy stupid fix and is functionality that's already in the desktop qml view. Without this, none of my supporters on iOS can test my new lighting package written in native c. |
Owner
|
Sorry about the delay, I didn't see this one. Have you tested this code? To me it looks like it wont work as the timer only will load one of the custom configs. I think the logic around the load timer needs to be changed for this to work reliably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the desktop version would show additional custom configs. I modified the mobile view too so they would show up. Related to vedderb/vesc_express#69