DS1/DS1R General Param Community Name Overhaul (V2)#355
Draft
treacherousfiend wants to merge 1 commit intovawser:mainfrom
Draft
DS1/DS1R General Param Community Name Overhaul (V2)#355treacherousfiend wants to merge 1 commit intovawser:mainfrom
treacherousfiend wants to merge 1 commit intovawser:mainfrom
Conversation
Bring over the changes from the old PR (vawser#277) to the new one, since Smithbow handles row names differently now. Currently only has DS1R rows.
39 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #277, which was started before the format of community row names changed
An overhaul to the General Param community names for DS1/DS1R.
Not all of the params are done yet, but I figured I'd put up a draft PR to get feedback on formatting and the like.
Aside from minor fix commits, every param is split into its own commit to make looking at changes easier
Param List
I do also have some notes on my changes to give reasoning for changes, or to mark a translation I am unsure of.
Character Names
Many names have been replaced with what the DS1R FuturePress guidebook calls them, as I would consider it more up to date and accurate than the original DS1 guidebook. Although with that said, in some cases the game itself has more than one name for a character, and sometimes that is slightly different than the guidebook. For example, NPC summons/invasions usually will have a shorter name compared to the NPC's more formal title ("Knight Solaire" in game vs "Solaire of Astora" in the guidebook).
I hope using DS1R guidebook names doesn't cause any confusion, because basically every wiki has at least a few incorrect names (in the case of the Wikidot its mostly that they use the old DS1 guidebook names. For fextralife its because its absolute garbage and has just made up names)
Class name translations:
Many older machine translations have some of the classes incorrect, so I wanted to show how I've changed them based on cross-referencing how the params are used as well as the kanji vs translations which were already correct.
I don't think I actually changed any param names for this, but I do want to make note of it. "Marvellous" in Marvellous Chester's name is using the UK English spelling of the word, even though the game I believe mostly uses US English? However the messages for when he invades you and the guidebook call him "Marvelous Chester" with the US English spelling (1 L rather than 2). I've decided to stick with the UK spelling that he is called in his own dialogue.
Unused params named "Witch Mallows" has been changed to "Witch Beatrice". This one is a bit of a stretch since all but one param still named "Witch Mallows" (or "魔女マロース") is unused. Witch Beatrice's params are all called simply "Witch" (or "魔女"), except the FaceGenParam she uses, which was named "魔女マロース", so I'm assuming its the same character. Since this is unused content, I could definitely see leaving it as is.
For NPCs that have multiple variants, I've added little descriptive labels to their name to clarify which one they are, including:
Area Names
Mostly just in case someone wants to know what the internal names actually refer to
Other
I've replaced references to "DS2" with "DeS2", to clarify that it is meant to be for "Demon's Souls 2" (aka Dark Souls 1), rather than for Dark Souls 2.
Although tbh it probably would be better to replace it with something like "DS1 Proto".
the Skeleton NpcThinkParams that are labelled with '"Lunging Drill" Attack' are the ones that do that weird emperor palpatine jump and spin attack at you in the Catacombs. A translation of the JP is more like "Screw" attack, but this is another thing where I decided to take the name from the guidebook, since i figured anything I came up with would probably be confusing to someone no matter what and at least the guidebook name is kinda official.
Needs better translations
My Japanese skills are very very beginner, and while my translations aren't just dropped into machine translation, I did make heavy use of a dictionary and google translate, the latter of which mostly to just try and understand context a bit better, although even the raw output from that now is a hell of a lot better than whatever was used to machine translate many of these params like over a decade ago.
Because of this I hope someone that has much better knowledge of Japanese can come and double check my work
These are listed by ID, not index.
NpcParam:
NpcThinkParam:
Mostly the same unsure translations as NpcParam, but there are a few ones unique to this param
MenuColorTableParam:
MoveParam:
Mostly DeS stuff that I'm not as familiar with
GameAreaParam:
LockCamParam: