Skip to content

Conversation

@adam-fowler
Copy link
Collaborator

This should make it easier to add distributed tracing to pipeline and transaction

Signed-off-by: Adam Fowler <adamfowler71@gmail.com>
@github-actions
Copy link

❌ Pull request has performance regressions ❌

Summary
================================================================================
Threshold deviations for ValkeyBenchmarks:Connection: GET benchmark – NoOpTracer
================================================================================
Malloc (total) (#, %) main pull_request Difference % Threshold %
p25 6975 7743 11 5

New baseline 'pull_request' is WORSE than the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '190e13ff7465' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 51 51 54 55 56 56 56 7
pull_request 50 52 54 55 56 56 56 7
Δ -1 1 0 0 0 0 0 0
Improvement % 2 -2 0 0 0 0 0 0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 49 53 55 56 59 63 63 30
pull_request 49 53 54 56 58 61 61 29
Δ 0 0 -1 0 -1 -2 -2 -1
Improvement % 0 0 2 0 2 3 3 -1

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 4 4 4 4 4 4 4 9
pull_request 4 4 4 4 4 4 4 9
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 4 7 8 9 9 9 9 8
pull_request 4 8 8 9 9 9 9 9
Δ 0 1 0 0 0 0 0 1
Improvement % 0 -14 0 0 0 0 0 1

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 9 20 24 27 30 30 30 9
pull_request 9 20 24 27 30 30 30 9
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 7 24 24 24 25 25 25 9
pull_request 7 24 24 24 25 25 25 9
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 21
pull_request 0 0 0 0 0 0 0 21
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 1000
pull_request 0 0 0 0 0 0 0 1006
Δ 0 0 0 0 0 0 0 6
Improvement % 0 0 0 0 0 0 0 6

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 2471
pull_request 0 0 0 0 0 0 0 2517
Δ 0 0 0 0 0 0 0 46
Improvement % 0 0 0 0 0 0 0 46

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 444
pull_request 0 0 0 0 0 0 0 461
Δ 0 0 0 0 0 0 0 17
Improvement % 0 0 0 0 0 0 0 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants