docs: add progress-bar base style properties to JSDoc #10634
+36
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
reviewed
Dec 15, 2025
| * | ||
| * Custom property | Description | Default | ||
| * ----------------|-------------|------------- | ||
| * `--vaadin-progress-value` | current progress value (between 0 and 1) | 0 |
Contributor
There was a problem hiding this comment.
Should we prefix it with _?
Member
Author
There was a problem hiding this comment.
IMO we could, but let's probably keep it as is just in case someone relies on the current property name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #9617
Added base style properties and removed
--vaadin-progress-valueas it's set by the component itself and not supposed to be modified from outside - so in a way, it can be considered internal (also, we don't list it in the new styling docs).Type of change