refactor: remove unnecessary will-change: transform #10631
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
approved these changes
Dec 12, 2025
Member
There was a problem hiding this comment.
In general, MDN recommends using will-change only to deal with some existing performance problems but not to anticipate them.
I assume these styles were added years ago to tackle some performance bottlenecks, but they no longer seem to serve that purpose.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
will-change: transformon every frozen grid cell does not appear to have any performance benefit (tested internally with grid benchmark). At the same time, it forces the browser to create many unjustified composition layers.As a general rule, MDN recommends using will-change only to deal with existing performance problems:
Type of change