Skip to content

Conversation

@ugur-vaadin
Copy link
Contributor

Description

This PR updates Popover's _updatePosition() to constrain overlays to viewport boundaries by calculating the centered position and adjusting if it would exceed left or right viewport edges.

Fixes #7750

Type of change

  • Bugfix
  • Feature
  • Refactor

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@ugur-vaadin ugur-vaadin marked this pull request as draft December 8, 2025 16:48
@ugur-vaadin ugur-vaadin marked this pull request as ready for review December 9, 2025 08:02
@ugur-vaadin ugur-vaadin marked this pull request as draft December 9, 2025 08:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@ugur-vaadin ugur-vaadin marked this pull request as ready for review December 9, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tooltip] When using botom / top position, overlay can be partially outside viewport

2 participants