fix: completion generation for Fish #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First things first: Thank you for creating this feature, I find it quite useful
I'm a Fish Shell user, and I noted that the
uvcompletion was not working, after looking at the code and test in my computer, I solved it removing thesourcecommand from the pipe.Here is the template that I used to test the feature as it is right now:
{ "name": "Python", "image": "mcr.microsoft.com/devcontainers/python:1-3.13-bookworm", "features": { "ghcr.io/va-h/devcontainers-features/uv:1": {"shellautocompletion": true}, "ghcr.io/meaningful-ooo/devcontainer-features/fish:1": {} } }The following command did not work on an out of the box fish shell:
But this one did:
uv generate-shell-completion fish >> /home/vscode/.config/fish/config.fish