Skip to content

Conversation

@mmartinortiz
Copy link
Contributor

Hi,

After our previous conversation in #8 , I thought that would be nice to install all the completions globally. In that way, the user does not have to keep in mind the order of the features.

I have tested this with bash, zsh and fish. As I could not find a devcontainer feature for elvish, I left the code for that shell untouched.

Let me know what you think.

@va-h va-h merged commit 32ddc25 into va-h:main Feb 24, 2025
9 checks passed
@va-h
Copy link
Owner

va-h commented Feb 24, 2025

Hi,
thank you for the pull request. I think this might be a solution but we have to see, for now I think it's good the autocompletion isn't enabled by default because I had to change the base image to get the tests working again. Depending on the underlying image it will probably still race with fish.

I also removed elvish completely, I tried to make it work somehow but don't see a way to get this done within a reasonable timeframe right now.

@mmartinortiz
Copy link
Contributor Author

I had to change the base image to get the tests working again. Depending on the underlying image it will probably still race with fish.

Could it be that the path where the completions are going to be saved does not exist yet? We could include a mkdir -p <path> to create the destination before saving the completions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants