Improved message for outdated TPL and removed possibly confusing println#2666
Improved message for outdated TPL and removed possibly confusing println#2666DavyLandman merged 5 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2666 +/- ##
=======================================
Coverage 46% 46%
- Complexity 6680 6682 +2
=======================================
Files 795 795
Lines 65902 65902
Branches 9880 9880
=======================================
+ Hits 30714 30719 +5
+ Misses 32810 32801 -9
- Partials 2378 2382 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| throw rascalTplVersionError(msg); | ||
| } | ||
| qualifiedModuleName = moduleId2moduleName(moduleId); | ||
| return <false, tmodel(modelName=qualifiedModuleName, messages=[error("Cannot read TPL for <qualifiedModuleName>", tplLoc)]), ms>; |
There was a problem hiding this comment.
I think it shouldn't be reported on the tplLoc that is not a file a user can open in an IDE, it might be a related loc, but not the main loc.
There was a problem hiding this comment.
In principle, I agree, but we may not have anything else to point to: this can be a tpl file for which no source is available. I will ponder on other options ...
|
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
This looks like a good error message and reporting!
2 participants
No description provided.