Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2616 +/- ##
=======================================
Coverage 46% 46%
- Complexity 6643 6659 +16
=======================================
Files 793 794 +1
Lines 65719 65746 +27
Branches 9844 9852 +8
=======================================
+ Hits 30602 30629 +27
+ Misses 32759 32754 -5
- Partials 2358 2363 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feb2812 to
745a65f
Compare
Member
Author
|
@PaulKlint Can you please confirm which of the copies should remain? |
745a65f to
8039269
Compare
DavyLandman
reviewed
Jan 29, 2026
PaulKlint
reviewed
Jan 30, 2026
Member
PaulKlint
left a comment
There was a problem hiding this comment.
See remarks. It is fine to remove these functions.
PaulKlint
reviewed
Jan 30, 2026
src/org/rascalmpl/compiler/lang/rascalcore/check/tests/StaticTestingUtils.rsc
Outdated
Show resolved
Hide resolved
PaulKlint
requested changes
Jan 30, 2026
Member
PaulKlint
left a comment
There was a problem hiding this comment.
Looks fine, except extend in StaticTestingUtils
Member
Author
|
This needs the changes pending in usethesource/typepal#34 |
f997255 to
70eec9e
Compare
DavyLandman
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some functions, copies of which also exist here:
https://github.com/usethesource/typepal/blob/60cb6ea4febf0bf1152ec0d81279ebacc7beaaf6/src/analysis/typepal/Collector.rsc#L35-L40