Improve handling of ignored modules in renaming#626
Open
toinehartman wants to merge 8 commits intomainfrom
Open
Improve handling of ignored modules in renaming#626toinehartman wants to merge 8 commits intomainfrom
toinehartman wants to merge 8 commits intomainfrom
Conversation
Member
|
Hmm, I thought the |
Member
Author
Currently, the compiler does not produce a TModel for Btw, this PR currently fails with a run-time error w.r.t. |
toinehartman
force-pushed
the
fix/rename-refactoring/ignored-modules
branch
from
80fac65 to
9353c51
Compare
toinehartman
force-pushed
the
fix/rename-refactoring/ignored-modules
branch
from
9353c51 to
a04d8e7
Compare
toinehartman
force-pushed
the
fix/rename-refactoring/ignored-modules
branch
from
a04d8e7 to
9bd9f05
Compare
toinehartman
force-pushed
the
fix/rename-refactoring/ignored-modules
branch
from
9f929ba to
1f91cb4
Compare
toinehartman
force-pushed
the
fix/rename-refactoring/ignored-modules
branch
from
cb0be92 to
3963bb7
Compare
toinehartman
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly support ignored modules in renaming.
Discovered in #588 and was blocked by usethesource/rascal#2513 for a while.