This repository was archived by the owner on Jun 19, 2023. It is now read-only.
feat: added a new interop structure example#2
Open
Giacomo-Papaluca wants to merge 2 commits intodevelopfrom
Open
feat: added a new interop structure example#2Giacomo-Papaluca wants to merge 2 commits intodevelopfrom
Giacomo-Papaluca wants to merge 2 commits intodevelopfrom
Conversation
LiamThys
suggested changes
May 5, 2022
| @@ -0,0 +1,18 @@ | |||
| @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> | |||
There was a problem hiding this comment.
@Prefix declaration should end with .
Change declarations in all files
Suggested change
| @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> | |
| @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> . |
| interop:registeredAt "2020-04-04T20:15:47.000Z"^^xsd:dateTime ; | ||
| interop:updatedAt "2020-04-04T21:11:33.000Z"^^xsd:dateTime ; | ||
| interop:registeredAgent projectron:\#id ; | ||
| interop:hasAccessGrant alice-agents:2f2f3628\/27eae14b . No newline at end of file |
There was a problem hiding this comment.
Declaration jack-agents instead of alice-agents.
Happens in some other files so check other files and change there as well.
Suggested change
| interop:hasAccessGrant alice-agents:2f2f3628\/27eae14b . | |
| interop:hasAccessGrant jack-agents:2f2f3628\/27eae14b . |
| jack-agents: | ||
| a interop:AgentRegistry ; | ||
| interop:hasSocialAgentRegistration | ||
| alice-agents:c4562da9\/ , # Alice |
There was a problem hiding this comment.
Suggested change
| alice-agents:c4562da9\/ , # Alice | |
| alice-agents:c4562da9\/ ; # Alice |
| interop:hasSocialAgentRegistration | ||
| alice-agents:c4562da9\/ , # Alice | ||
| interop:hasApplicationRegistration | ||
| alice-agents:2f2f3628\/ , # Projectron |
There was a problem hiding this comment.
Suggested change
| alice-agents:2f2f3628\/ , # Projectron | |
| alice-agents:2f2f3628\/ . # Projectron |
| @@ -0,0 +1,15 @@ | |||
| @prefix jack: <https://localhost:3000/jackpapa> | |||
There was a problem hiding this comment.
Missing some declarations
Suggested change
| @prefix jack: <https://localhost:3000/jackpapa> | |
| @prefix foaf: <http://xmlns.com/foaf/0.1/>. | |
| @prefix solid: <http://www.w3.org/ns/solid/terms#>. | |
| @prefix auth-agent: <http://localhost:4200/>. | |
| @prefix interop: <http://www.w3.org/ns/solid/interop#>. | |
| @prefix jack: <https://localhost:3000/jackpapa>. |
| @prefix jack-agents: <https://localhost:3000/jackpapa/agents/> | ||
| @prefix pm-shapetrees: <http://data.example/shapetrees/pm#> | ||
|
|
||
| alice-authorization:54a1b6a0 |
There was a problem hiding this comment.
Suggested change
| alice-authorization:54a1b6a0 | |
| jack-authorization:54a1b6a0 |
| @@ -0,0 +1,15 @@ | |||
| @prefix jack: <https://localhost:3000/jackpapa> | |||
There was a problem hiding this comment.
Suggested change
| @prefix jack: <https://localhost:3000/jackpapa> | |
| @prefix foaf: <http://xmlns.com/foaf/0.1/>. | |
| @prefix solid: <http://www.w3.org/ns/solid/terms#>. | |
| @prefix auth-agent: <http://authz-agent.example>. # fake uri | |
| @prefix interop: <http://www.w3.org/ns/solid/interop#>. | |
| @prefix jack: <https://localhost:3000/jackpapa>. |
| @@ -0,0 +1,16 @@ | |||
| @prefix interop: <http://www.w3.org/ns/solid/interop#> | |||
There was a problem hiding this comment.
Same for projectron as with the social agents this will be in the pod of projectron. An application registration refers to this interop:application with interop:registeredAgent
| jack:registries | ||
| a interop:RegistrySet; | ||
| interop:HasAgentRegistry jack:agents\/; | ||
| interop:hasAuthorizationRegistry jack:authorizations\/; |
There was a problem hiding this comment.
Suggested change
| interop:hasAuthorizationRegistry jack:authorizations\/; | |
| interop:hasAuthorizationRegistry jack:authorizations\/. |
| @@ -0,0 +1,18 @@ | |||
| @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> | |||
There was a problem hiding this comment.
@Prefix declaration should end with .
Change this in every file.
Useful tool to check turtle syntax: http://ttl.summerofcode.be/
Suggested change
| @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> | |
| @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.