This repository was archived by the owner on May 12, 2023. It is now read-only.
Open
Conversation
Gundwane21
changed the title
oguzhancvdr
reviewed
Dec 11, 2021
oguzhancvdr
left a comment
oguzhancvdr
left a comment
There was a problem hiding this comment.
- Ideally, your commits should be seperated for each grouped process.
- for example: you created an endpoint for baskets app so just commit changes related with baskets. Thanks to it, your code reviewers can easliy inspect your changes
upy
suggested changes
Dec 11, 2021
ecommerce/baskets/filters.py
Outdated
| """ | ||
| Basket Models Filter | ||
| """ | ||
| status = filters.CharFilter(label=_("Status")) |
Owner
There was a problem hiding this comment.
bu satiri neden ekleme ihtiyaci hissettik?
ecommerce/baskets/serializers.py
Outdated
|
|
||
| class Meta: | ||
| model = BasketItem | ||
| fields = ("basket", "product", "quantity", "price",) |
ecommerce/orders/filters.py
Outdated
|
|
||
| class ShippingAddressFilter(filters.FilterSet): | ||
| full_name = filters.CharFilter(label=_("Full Name")) | ||
| city = CityFilter |
Owner
There was a problem hiding this comment.
boyle bir kullanimi nereden ogrendik?
Author
|
Code is edited following the instructors feedbacks. Problems are resolved. The following changes can be found in the following commit: 178fd14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For each app such as baskets, customers, orders, payments ; their corresponding filter, serializer and view functionality is added. In addition, all these are registered to router to redirect from /api.