dark mode added to the component#42
Open
Anurag-NURA wants to merge 1 commit intoupnotes-io:masterfrom
Open
Conversation
bhujoshi
reviewed
Oct 25, 2022
| "dependencies": { | ||
| "clsx": "^1.2.1" | ||
| "clsx": "^1.2.1", | ||
| "react-todo-component": "^2.0.3" |
Contributor
There was a problem hiding this comment.
Remove react-todo-component dependency
| setItems([...updatedItems, ...completedItems]); | ||
| }; | ||
|
|
||
| const [theme, setTheme] = useState("light-theme"); |
Contributor
There was a problem hiding this comment.
As people will use react-todo as an external dependency. Can you expose a prop to control the theme? instead of using local state. Just make light-theme default value for the prop.
Author
There was a problem hiding this comment.
I am not so sure how to create a prop that can be later used as optional feature. As I am very new in react, I only know Javascript, I don't have idea about Typescript. But I will let you know if I am able to make a prop for the feature.
| use-latest "^1.0.0" | ||
|
|
||
| react-todo-component@^2.0.3: | ||
| version "2.0.3" |
Contributor
There was a problem hiding this comment.
Not needed react-todo-component.
Contributor
|
@Anurag-NURA thanks. I have added a few review comments please have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created the dark mode feature for the component