Optionally use AppIndicator for system tray#315
Open
trigg wants to merge 1 commit intouowuo:masterfrom
Open
Conversation
- Alternative codepath for appindicator where possible
Member
|
is there any reason someone might want to not use appindicator even if they have it installed? idk if maybe it should have a cmake option |
Contributor
Author
|
I wouldn't say 'never' but as AppIndicator falls back to Gtk StatusIcon internally if there's no appindicator service to use, I'd argue it covers ground better (except for Mac/Windows) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds extra codepath to use libappindicator to show system tray icon
Benefits:
(although I've not proven this with a test)Tested in distroboxDownsides:
Other considerations:
Packaging:
apt install libappindicator3-devpacman -S libappindicator-gtk3