-
Notifications
You must be signed in to change notification settings - Fork 16
fix: notification display and functionality + nuxtui refactor #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Ajit-Mehrotra
wants to merge
66
commits into
main
Choose a base branch
from
refactor/rebased-nuxtui-notifiactions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12,989
−1,189
Draft
Changes from all commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
d07aa42
table > select & status badge
pujitm a32dd21
enhance: add ssh retry logic and SSH options in deploy script
Ajit-Mehrotra 29312d7
refactor: replace LoadingSpinner and LoadingError with nuxtUI components
Ajit-Mehrotra a8459c7
fix: address notification pane infinite network request and improve e…
Ajit-Mehrotra 7679d71
refactor: update notification components to use UIcon and UButton for…
Ajit-Mehrotra e80ea79
refactor: enhance app configuration and notification components for i…
Ajit-Mehrotra 88766ad
refactor(ui): replace vue-sonner toasts with nuxtui toasts
Ajit-Mehrotra 4798c89
fix(notifications api): implement async generator for improve filteri…
Ajit-Mehrotra 80bbf2d
fix(notification): address filenames greater than 255 bytes
Ajit-Mehrotra 9f27eb7
refactor(notifications): sync toast position with legacy settings
Ajit-Mehrotra 1000976
fix(app.config): update toast max duration comment for compatibility …
Ajit-Mehrotra c21ecc7
fix(notifications): override notification bell hover to maintain cons…
Ajit-Mehrotra 67ac307
fix(notifications): add break-word styling for long words in subject …
Ajit-Mehrotra be1e2f5
fix(notifications): add elipses to long single-word toast titles
Ajit-Mehrotra fe74e53
fix(notifications): show full title on notification pane and truncate…
Ajit-Mehrotra f690c23
fix(notifications): add support for bottom-center'd nuxtui toasts
Ajit-Mehrotra f7fe959
chore(gitignore): add .dev-scripts to gitignore for local dev scripts
Ajit-Mehrotra 875aa09
fix(notifications): fix color of notification button's active state
Ajit-Mehrotra 6a04a06
fix(notification): add min width to allow flex title to shrink and wr…
Ajit-Mehrotra e3bf571
fix(notifications): resolve ID mismatches, counter bugs, and paginati…
Ajit-Mehrotra 2122e6d
feat(notifications): add notify script for backup and restore on plug…
Ajit-Mehrotra ddd6b0b
Revert "fix(notifications): add support for bottom-center'd nuxtui to…
Ajit-Mehrotra 4a19d4d
fix(notifications): enable user overrides for the header text color
Ajit-Mehrotra 4c42b4b
fix(notifications): update notify script's filename sanitization to i…
Ajit-Mehrotra 53ee465
fix: resolve no-undef lint errors for auto-imported composables in Vu…
Ajit-Mehrotra 6458457
feat(components): add DockerContainerStatCell and USlideover componen…
Ajit-Mehrotra d10e054
feat(notifications): replace docker toast usage with nuxtui toast com…
Ajit-Mehrotra fd1a046
feat(notifications): integrate nuxtui toast composable for success me…
Ajit-Mehrotra 7969e44
refactor(navigation): replace window.location with navigate helper fo…
Ajit-Mehrotra e61657c
refactor(notification): use "size" for square css widths and height
Ajit-Mehrotra c18de73
refactor(notifications): center notification error button text
Ajit-Mehrotra ad78a02
feat(errors): add dbgApolloError function for enhanced GraphQL error …
Ajit-Mehrotra c2d2fbe
feat(notifications): introduce constants for notification icons and c…
Ajit-Mehrotra e817d6a
fix(notifications): add onResult handler to update online status base…
Ajit-Mehrotra 4abc79a
fix(notifications): sync badges on api recovery
Ajit-Mehrotra 17f0176
fix(notifications): set 'top-right' as default toast location
Ajit-Mehrotra 4c49baf
chore(dependencies): update @nuxt/ui to version 4.2.1 from 4.0.0 alpha
Ajit-Mehrotra 1e5decc
Revert "Revert "fix(notifications): add support for bottom-center'd n…
Ajit-Mehrotra 88e76d7
feat(notifications): update nuxtui to 4.2.1 and add new toast features
Ajit-Mehrotra a8578bf
refactor(notifications): move ToastPosition type to a separate file a…
Ajit-Mehrotra 3c9c04d
wip(css-modification): add DefaultBaseCssModification class for CSS s…
Ajit-Mehrotra 5628bf9
fix(color): fix bell icon color in header to work on all themes
Ajit-Mehrotra 2f88228
fix(theme): adjust logo overlap on azure/gray themes on unraid versio…
Ajit-Mehrotra 902307a
feat(notifications): add file-modification scripts for nuxtui notific…
Ajit-Mehrotra b456678
fix: update file-modification location for default-base.css
Ajit-Mehrotra 716789f
fix: add generated files + patch + snapshot files
Ajit-Mehrotra 8ef00ce
chore: lint
Ajit-Mehrotra 9ed71e5
chore: rebase cleanup
Ajit-Mehrotra ad2a5cc
test(notifications): Update various api and web component tests
Ajit-Mehrotra 443335e
fix: update header background file modification
Ajit-Mehrotra 00f015f
test(notifications): update patch files
Ajit-Mehrotra 1c4f33e
Revert "fix: update header background file modification"
Ajit-Mehrotra b0ff85b
Revert "test(notifications): update patch files"
Ajit-Mehrotra 9504b4a
fix(css): file-modifications for backwards compatability with 7.0
Ajit-Mehrotra 18f3227
fix: default-gray theme's header background color via a file-modifier.
Ajit-Mehrotra bff05e0
fix(web): remove incorrect toaster mapping causing empty notification
Ajit-Mehrotra 86ec429
fix(css): add @layer in default-base file modifier to ensure css spec…
Ajit-Mehrotra 4ee5506
test: update snapshots and patch files for default-base.css file-modi…
Ajit-Mehrotra f23e5bc
fix: clean up rebase
Ajit-Mehrotra 41aa09f
build(scripts): enhance local docker plugin development workflow
Ajit-Mehrotra 736c24c
chore: prevent automatic formatting of .page files (interpretted as .…
Ajit-Mehrotra e140863
feat(toast): finish migration to nuxtui toasts (finished migrating ne…
Ajit-Mehrotra aa2c6eb
chore: remove legacy Toaster.vue and related components from monorepo
Ajit-Mehrotra eae2651
test: update file modification tests
Ajit-Mehrotra d8f3e92
fix: remove unused import
Ajit-Mehrotra de860cb
fix: add file-modification for font-awesome.css
Ajit-Mehrotra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "files.associations": { | ||
| "*.page": "php" | ||
| }, | ||
| "intelephense.format.enable": false, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,4 +86,4 @@ unraid-sso-button.unapi { | |
| --text-7xl: 4.5rem; | ||
| --text-8xl: 6rem; | ||
| --text-9xl: 8rem; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,4 +65,4 @@ | |
| /* Dark Mode Overrides */ | ||
| .dark { | ||
| --color-border: #383735; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const DOCKER_SERVICE_TOKEN = Symbol('DOCKER_SERVICE'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing comma in JSON object.
The JSON file has a syntax error: a trailing comma after
"intelephense.format.enable": false,before the closing brace. JSON does not permit trailing commas, and this will cause VS Code to fail parsing the settings file.🔎 Proposed fix
{ "files.associations": { "*.page": "php" }, - "intelephense.format.enable": false, + "intelephense.format.enable": false }📝 Committable suggestion
🧰 Tools
🪛 Biome (2.1.2)
[error] 5-6: Expected a property but instead found '}'.
Expected a property here.
(parse)
🤖 Prompt for AI Agents