Fix PCP auth redirect and restore dynamic menu/header loading#252
Merged
unclehowell merged 3 commits intogh-pagesfrom Feb 21, 2026
Merged
Fix PCP auth redirect and restore dynamic menu/header loading#252unclehowell merged 3 commits intogh-pagesfrom
unclehowell merged 3 commits intogh-pagesfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Deploying carfinance with
|
| Latest commit: |
1dc2154
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6208e5f.carfinance.pages.dev |
| Branch Preview URL: | https://codex-fix-stylesheet-and-men.carfinance.pages.dev |
Deploying dcc with
|
| Latest commit: |
1dc2154
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9dc605b2.dcc-cwd.pages.dev |
| Branch Preview URL: | https://codex-fix-stylesheet-and-men.dcc-cwd.pages.dev |
Deploying ccan-homepage with
|
| Latest commit: |
1dc2154
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1685597e.ccan-homepage.pages.dev |
| Branch Preview URL: | https://codex-fix-stylesheet-and-men.ccan-homepage.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/login.htmloutside the app path which caused a broken post-load navigation and disappearance of header styles and menu content.Description
static/pcp/index.htmlto redirect unauthenticated users to/static/pcp/login.htmland keep auth navigation within the PCP app path.static/pcp/login.htmlto redirect authenticated users back to/static/pcp/index.htmlfor both the already-authenticated and successful-login flows.static/pcp/js/menu-loader.jswith a robust loader that tries relative and absolute PCP paths, parses response text (not relying on content-type), preserves icons, marks nested items withdata-lte-toggle="treeview", and dispatches amenuLoadedevent after rendering.static/pcp/js/header-loader.jswith the same resilient JSON-fallback approach and stable header rendering.Testing
node -eevaluated both loader files successfully).python3 -m http.server --directory ...) and behaved as expected./static/pcp/index.htmlredirect to/static/pcp/login.htmland authenticated visits stay on the dashboard and populate the sidebar (the automated script detected 33 menu items); screenshots were captured showing the restored dashboard state.Codex Task