🎨 Constraint function plots in plot_proc
#4049
Conversation
…djust font sizes and add new plots in main function
…d normalization and improve axis annotations
chris-ashe
added
the
Input/Output Files
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4049 +/- ##
==========================================
+ Coverage 46.49% 46.62% +0.12%
==========================================
Files 123 123
Lines 28777 29530 +753
==========================================
+ Hits 13381 13769 +388
- Misses 15396 15761 +365 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lace dashed line with arrow annotation, and remove relative change text display
…on to ensure proper string formatting
…function for improved clarity
…ght, add z-order for layering, and improve text annotation with dynamic color and background
|
@chris-ashe could you add an image of the new output here? |
Have added to main PR text now |
jonmaddock
left a comment
jonmaddock
left a comment
There was a problem hiding this comment.
Great to have this working, such an improvement to our visualisation! Main points are about calculating stuff that has either been calculated already (I think) or should have been, e.g. normalisation of constraint/bound values.
| constraint_bound = con2[i] | ||
|
|
||
| # assumes f-value is 1 | ||
| # -cc because sign is reversed in constraint_eqns |
There was a problem hiding this comment.
Can you be totally clear here: after the sign change here, a constraint > 0 is violated, right? i.e. the convention.
There was a problem hiding this comment.
From my understanding and by the data the plots make it seems to be the correct way. @timothy-nunn what do you think?
There was a problem hiding this comment.
In PROCESS, a negative cc indicates that a constraint is violated
| # Plot main plasma information | ||
| plot_main_plasma_information( | ||
| figs[3].add_subplot(111, aspect="equal"), | ||
| figs[4].add_subplot(111, aspect="equal"), |
There was a problem hiding this comment.
This churn is a bit of a pain. Could figs just be appended to?
|
This looks fantastic now! |
There was a problem hiding this comment.
I'm not sure the equality constraint plot is doing anything for me. Its quite hard to meaningfully plot the residuals of these constraints especially given the different orders of magnitude. Would this be better as just a table?
The inequality bar chart should show margin so the bars should come from the right for
|
@chris-ashe when you have actioned all of Jon's comments can you please re-request his review |
This pull request enhances the post-optimization reporting for constraint handling in
process/scan.py. The main improvements involve adding more detailed output for both equality and inequality constraints, including physical values, units, symbols, and bounds, which should make debugging and analysis easier.Enhanced constraint reporting:
process_output.ovarre, improving the detail of post-optimization logs.Output formatting improvements:
Checklist
I confirm that I have completed the following checks: