Fix ConfigParser on py3, fix port/dbid not being cast #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use six to import ConfigParser (it's lowercase in py3). Fix incorrect variable usage, should be _application. Fix redis config not being cast to ints like in ddns_plugin.py.
Author
|
Just noticed some of these are in your feature branches. Can I ask what the intention of the mehr module is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues in ddns.tac.
I used this as a base for spawning the application and noticed some issues.
ConfigParsermodule is lowercase in Py3. Used six to support both.applicationdoesnt exist and should be_applicationddns_plugin.py) or an error resultsI added six to Pipfile, but not Pipfile.lock as I don't use these format files.