Add missing default.project.json
#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name = "cameronpcampbell/typeforge" | ||
| description = "A Type Function utility library." | ||
| version = "2.1.0" | ||
| version = "3.0.0" |
Collaborator
There was a problem hiding this comment.
Can you change the version to 2.1.1 as the changes only constitutes a minor patch in my opinion. 😄
Contributor
Author
There was a problem hiding this comment.
The change is major because it breaks compatibility with previous versions of the package.
It breaks compatibility because, previously, to import the package (both in wally and pesde), users were required to do
local typegorge = require(pathToTypeforge.src)which is no longer valid. Instead, it's now
local typegorge = require(pathToTypeforge)
Contributor
Author
There was a problem hiding this comment.
Making this a minor patch would make uses of the package that took versions 2.x.x break
Collaborator
There was a problem hiding this comment.
Oh yea, you're right - my bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default.project.jsonis missing, which means that to import Typeforge, users must actually dorequire(typeforgePath.src). It also causes issues with tools such as pesde's core scripts. It currently throws a mystic panic there (see pesde-pkg/scripts#8), which makes using the module impossible.This update requires a major version release.