Open
Conversation
Member
Author
juliapocciotti
approved these changes
Jun 21, 2021
| def __init__(self, cov_matrix: pd.DataFrame): | ||
|
|
||
| self._cov_matrix = cov_matrix | ||
| self._columns = cov_matrix.columns |
Member
There was a problem hiding this comment.
Se colocarem uma cov_matrix numpy não funciona, infelizmente esse typing nao faz verificação dinâmica
turingquant/optimizers.py
Outdated
|
|
||
| return seriation_columns | ||
|
|
||
| def _recursive_besection(self, seriation_columns): |
Member
There was a problem hiding this comment.
O nome dessa função é besection msm?
guilhermefgs
approved these changes
Jun 24, 2021
Member
guilhermefgs
left a comment
guilhermefgs
left a comment
There was a problem hiding this comment.
Dá uma olhada nos comentários que eu deixei. Talvez seja necessário fazer alguma alteração.
Falando sobre a estrutura de diretorios, eu preferiria que optimizers fosse um diretorio, e dentro dele tivesse HierachicalRiskParity.py e Markowitz.py. Eu acho que fica mais organizado.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.