Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates multiple API endpoints under a single TTXClientApi, updates configuration settings, and revises documentation and setup details to reflect the new API structure.
- Removed imports of individual APIs in favor of TTXClientApi.
- Added a new configuration file (config.yml) for API generation.
- Updated tests and documentation to use TTXClientApi and the new repository URL.
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ttx/api/init.py | Replaced multiple API imports with a single TTXClientApi import. |
| ttx/init.py | Updated API imports to use TTXClientApi. |
| test/test_ttx_client_api.py | Introduced test stubs for the new TTXClientApi endpoints. |
| setup.py | Updated the repository URL for the package. |
| pyproject.toml | Minor text change in description. |
| config.yml | Added configuration for API generation and tagging operations. |
| README.md | Revised installation, usage examples, and API endpoint documentation. |
Files not reviewed (3)
- .openapi-generator/FILES: Language not supported
- generate.ps1: Language not supported
- git_push.sh: Language not supported
Comments suppressed due to low confidence (1)
test/test_ttx_client_api.py:27
- The test case stubs currently use 'pass' and do not verify the API functionality. Consider adding assertions and concrete test scenarios to ensure proper test coverage for TTXClientApi.
pass
dylhack
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to keep APIs under single TTXClient
Also using config.yml
Updated generate script