Improve Makefile compatibility across different shells#7
Open
stevenskevin wants to merge 1 commit intotsgates:masterfrom
Open
Improve Makefile compatibility across different shells#7stevenskevin wants to merge 1 commit intotsgates:masterfrom
stevenskevin wants to merge 1 commit intotsgates:masterfrom
Conversation
The SHELL variable was causing very confusing differences in backslash escaping when running in different environments (e.g. Ubuntu vs Alpine Linux) due to differences in default shells. When it's not defined, Make uses /bin/sh by default, ensuring that escaping is performed more-or-less consistently. I also switched echo to printf, both for consistency with other parts of the Makefile and [to further improve cross-environment consistency](https://unix.stackexchange.com/a/65819).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SHELLvariable defined at the top of the Makefile was causing very confusing differences in backslash escaping when running in different environments (e.g. Ubuntu vs Alpine Linux) due to differences in default shells. When it's not defined, Make uses /bin/sh by default, ensuring that escaping is performed more-or-less consistently everywhere.I also switched echo to printf, both for consistency with other parts of the Makefile and to further improve cross-environment consistency.
This supersedes PR #6, which just fixed the issue for one particular shell without addressing the underlying root issue.