fix oversights in previous commit

Author: lockels

nova_vm/src/ecmascript/builtins/ordinary.rs

@@ -1688,7 +1688,10 @@ pub(crate) fn ordinary_object_create_with_intrinsics<'a>(
             agent.heap.create(InstantHeapData::default()).into_object()
         }
         #[cfg(feature = "temporal")]
-        ProtoIntrinsics::TemporalPlainTime => todo!(),
+        ProtoIntrinsics::TemporalPlainTime => agent
+            .heap
+            .create(PlainTimeHeapData::default())
+            .into_object(),
         ProtoIntrinsics::TypeError => agent
             .heap
             .create(ErrorHeapData::new(ExceptionType::TypeError, None, None))

nova_vm/src/ecmascript/builtins/temporal/plain_time.rs

@@ -6,9 +6,13 @@ use crate::{
         execution::{Agent, ProtoIntrinsics},
         types::{InternalMethods, InternalSlots, Object, OrdinaryObject, Value},
     },
-    engine::context::bindable_handle,
+    engine::{
+        context::{Bindable, bindable_handle},
+        rootable::{HeapRootData, HeapRootRef, Rootable},
+    },
     heap::{
-        CompactionLists, HeapMarkAndSweep, HeapSweepWeakReference, WorkQueues, indexes::BaseIndex,
+        CompactionLists, CreateHeapData, Heap, HeapMarkAndSweep, HeapSweepWeakReference,
+        WorkQueues, indexes::BaseIndex,
     },
 };
 
@@ -19,10 +23,6 @@ pub(crate) mod data;
 pub struct TemporalPlainTime<'a>(BaseIndex<'a, PlainTimeHeapData<'static>>);
 
 impl TemporalPlainTime<'_> {
-    pub(crate) fn inner_plain_date_time(self, agent: &Agent) -> &temporal_rs::PlainTime {
-        &agent[self].plain_time
-    }
-
     //TODO
     pub(crate) const fn _def() -> Self {
         TemporalPlainTime(BaseIndex::from_u32_index(0))
@@ -109,6 +109,29 @@ impl IndexMut<TemporalPlainTime<'_>> for Vec<PlainTimeHeapData<'static>> {
     }
 }
 
+impl Rootable for TemporalPlainTime<'_> {
+    type RootRepr = HeapRootRef;
+
+    fn to_root_repr(value: Self) -> Result<Self::RootRepr, HeapRootData> {
+        Err(HeapRootData::PlainTime(value.unbind()))
+    }
+
+    fn from_root_repr(value: &Self::RootRepr) -> Result<Self, HeapRootRef> {
+        Err(*value)
+    }
+
+    fn from_heap_ref(heap_ref: HeapRootRef) -> Self::RootRepr {
+        heap_ref
+    }
+
+    fn from_heap_data(heap_data: HeapRootData) -> Option<Self> {
+        match heap_data {
+            HeapRootData::PlainTime(object) => Some(object),
+            _ => None,
+        }
+    }
+}
+
 impl HeapMarkAndSweep for TemporalPlainTime<'static> {
     fn mark_values(&self, queues: &mut WorkQueues) {
         queues.plain_times.push(*self);
@@ -124,3 +147,11 @@ impl HeapSweepWeakReference for TemporalPlainTime<'static> {
         compactions.plain_times.shift_weak_index(self.0).map(Self)
     }
 }
+
+impl<'a> CreateHeapData<PlainTimeHeapData<'a>, TemporalPlainTime<'a>> for Heap {
+    fn create(&mut self, data: PlainTimeHeapData<'a>) -> TemporalPlainTime<'a> {
+        self.plain_times.push(data.unbind());
+        self.alloc_counter += core::mem::size_of::<PlainTimeHeapData<'static>>();
+        TemporalPlainTime(BaseIndex::last_t(&self.plain_times))
+    }
+}

nova_vm/src/ecmascript/types/language/object.rs

@@ -40,8 +40,7 @@ use crate::ecmascript::builtins::date::Date;
 use crate::ecmascript::builtins::{weak_map::WeakMap, weak_ref::WeakRef, weak_set::WeakSet};
 #[cfg(feature = "temporal")]
 use crate::ecmascript::{
-    builtins::temporal::plain_time::{self, TemporalPlainTime},
-    types::PLAIN_TIME_DISCRIMINANT,
+    builtins::temporal::plain_time::TemporalPlainTime, types::PLAIN_TIME_DISCRIMINANT,
 };
 #[cfg(feature = "proposal-float16array")]
 use crate::ecmascript::{builtins::typed_array::Float16Array, types::FLOAT_16_ARRAY_DISCRIMINANT};

nova_vm/src/engine/rootable.rs

@@ -108,7 +108,6 @@ use crate::{
                 promise_resolving_functions::BuiltinPromiseResolvingFunction,
             },
             proxy::Proxy,
-            temporal::plain_time,
             text_processing::string_objects::string_iterator_objects::StringIterator,
         },
         execution::{
@@ -143,7 +142,9 @@ pub mod private {
     #[cfg(feature = "date")]
     use crate::ecmascript::builtins::date::Date;
     #[cfg(feature = "temporal")]
-    use crate::ecmascript::builtins::temporal::instant::TemporalInstant;
+    use crate::ecmascript::builtins::temporal::{
+        instant::TemporalInstant, plain_time::TemporalPlainTime,
+    };
     #[cfg(feature = "array-buffer")]
     use crate::ecmascript::builtins::{
         ArrayBuffer,
@@ -239,6 +240,8 @@ pub mod private {
     impl RootableSealed for Date<'_> {}
     #[cfg(feature = "temporal")]
     impl RootableSealed for TemporalInstant<'_> {}
+    #[cfg(feature = "temporal")]
+    impl RootableSealed for TemporalPlainTime<'_> {}
     impl RootableSealed for ECMAScriptFunction<'_> {}
     impl RootableSealed for EmbedderObject<'_> {}
     impl RootableSealed for Error<'_> {}