bring up test262 test passing results, bug fixing, refactoring, groundwork for Temporal.PlainTime, WIP Temporal.prototype.round implementations.. probably should have committed more frequently lol

Author: lockels

nova_vm/src/builtin_strings

@@ -113,6 +113,8 @@ encodeURIComponent
 endsWith
 entries
 enumerable
+#[cfg(feature = "temporal")]epochMilliseconds
+#[cfg(feature = "temporal")]epochNanoseconds
 EPSILON
 #[cfg(feature = "temporal")]equals
 Error
@@ -149,8 +151,8 @@ for
 forEach
 freeze
 from
-fromEpochNanoseconds
-fromEpochMilliseconds
+#[cfg(feature = "temporal")]fromEpochNanoseconds
+#[cfg(feature = "temporal")]fromEpochMilliseconds
 fromCharCode
 fromCodePoint
 fromEntries
@@ -186,8 +188,8 @@ get size
 #[cfg(feature = "array-buffer")]getBigUint64
 #[cfg(feature = "date")]getDate
 #[cfg(feature = "date")]getDay
-#[cfg(feature = "temporal")]getEpochMilliseconds
-#[cfg(feature = "temporal")]getEpochNanoSeconds
+#[cfg(feature = "temporal")]get epochMilliseconds
+#[cfg(feature = "temporal")]get epochNanoseconds
 #[cfg(feature = "proposal-float16array")]getFloat16
 #[cfg(feature = "array-buffer")]getFloat32
 #[cfg(feature = "array-buffer")]getFloat64
@@ -320,6 +322,7 @@ parseFloat
 parseInt
 #[cfg(feature = "proposal-atomics-microwait")]pause
 #[cfg(feature = "math")]PI
+#[cfg(feature = "temporal")]PlainTime
 pop
 POSITIVE_INFINITY
 #[cfg(feature = "math")]pow

nova_vm/src/ecmascript/builtins/ordinary.rs

@@ -17,6 +17,7 @@ use caches::{CacheToPopulate, Caches, PropertyLookupCache, PropertyOffset};
 use crate::ecmascript::builtins::data_view::data::SharedDataViewRecord;
 #[cfg(feature = "temporal")]
 use crate::ecmascript::builtins::temporal::instant::data::InstantHeapData;
+use crate::ecmascript::builtins::temporal::plain_time::data::PlainTimeHeapData;
 use crate::{
     ecmascript::{
         abstract_operations::operations_on_objects::{
@@ -1686,6 +1687,8 @@ pub(crate) fn ordinary_object_create_with_intrinsics<'a>(
         ProtoIntrinsics::TemporalInstant => {
             agent.heap.create(InstantHeapData::default()).into_object()
         }
+        #[cfg(feature = "temporal")]
+        ProtoIntrinsics::TemporalPlainTime => todo!(),
         ProtoIntrinsics::TypeError => agent
             .heap
             .create(ErrorHeapData::new(ExceptionType::TypeError, None, None))
@@ -2074,6 +2077,10 @@ fn get_intrinsic_constructor<'a>(
         ProtoIntrinsics::WeakSet => Some(intrinsics.weak_set().into_function()),
         #[cfg(feature = "temporal")]
         ProtoIntrinsics::TemporalInstant => Some(intrinsics.temporal_instant().into_function()),
+        #[cfg(feature = "temporal")]
+        ProtoIntrinsics::TemporalPlainTime => {
+            Some(intrinsics.temporal_plain_time().into_function())
+        }
     }
 }
 

nova_vm/src/ecmascript/builtins/temporal.rs

@@ -5,6 +5,8 @@
 pub mod duration;
 pub mod error;
 pub mod instant;
+pub mod options;
+pub mod plain_time;
 
 use crate::{
     ecmascript::{
@@ -16,27 +18,45 @@ use crate::{
     heap::WellKnownSymbolIndexes,
 };
 
-pub(crate) struct TemporalObject;
+pub(crate) struct Temporal;
 
-impl TemporalObject {
+impl Temporal {
     pub fn create_intrinsic(agent: &mut Agent, realm: Realm<'static>, _: NoGcScope) {
         let intrinsics = agent.get_realm_record_by_id(realm).intrinsics();
         let object_prototype = intrinsics.object_prototype();
         let this = intrinsics.temporal();
 
-        let temporal_instant_constructor = intrinsics.temporal_instant();
+        let instant_constructor = intrinsics.temporal_instant();
+        let plain_time_constructor = intrinsics.temporal_plain_time();
 
         OrdinaryObjectBuilder::new_intrinsic_object(agent, realm, this)
-            .with_property_capacity(2)
+            .with_property_capacity(3)
             .with_prototype(object_prototype)
+            // 1.2.1 Temporal.Instant ( . . . )
             .with_property(|builder| {
                 builder
                     .with_key(BUILTIN_STRING_MEMORY.Instant.into())
-                    .with_value(temporal_instant_constructor.into_value())
+                    .with_value(instant_constructor.into_value())
                     .with_enumerable(false)
-                    .with_configurable(false)
+                    .with_configurable(true)
+                    .build()
+            })
+            // 1.2.2 Temporal.PlainDateTime ( . . . )
+            // 1.2.3 Temporal.PlainDate ( . . . )
+            // 1.2.4 Temporal.PlainTime ( . . . )
+            .with_property(|builder| {
+                builder
+                    .with_key(BUILTIN_STRING_MEMORY.PlainTime.into())
+                    .with_value(plain_time_constructor.into_value())
+                    .with_enumerable(false)
+                    .with_configurable(true)
                     .build()
             })
+            // 1.2.5 Temporal.PlainYearMonth ( . . . )
+            // 1.2.6 Temporal.PlainMonthDay ( . . . )
+            // 1.2.7 Temporal.Duration ( . . . )
+            // 1.2.8 Temporal.ZonedDateTime ( . . . )
+            // 1.3.1 Temporal.Now
             .with_property(|builder| {
                 builder
                     .with_key(WellKnownSymbolIndexes::ToStringTag.into())

nova_vm/src/ecmascript/builtins/temporal/instant.rs

@@ -12,7 +12,8 @@ use crate::{
     ecmascript::{
         abstract_operations::type_conversion::{PreferredType, to_primitive_object},
         builtins::{
-            ordinary::ordinary_create_from_constructor, temporal::duration::to_temporal_duration,
+            ordinary::ordinary_create_from_constructor,
+            temporal::{duration::to_temporal_duration, error::temporal_err_to_js_err},
         },
         execution::{
             JsResult, ProtoIntrinsics,
@@ -229,26 +230,38 @@ fn create_temporal_instant<'gc>(
 fn to_temporal_instant<'gc>(
     agent: &mut Agent,
     item: Value,
-    gc: GcScope<'gc, '_>,
+    mut gc: GcScope<'gc, '_>,
 ) -> JsResult<'gc, temporal_rs::Instant> {
     let item = item.bind(gc.nogc());
     // 1. If item is an Object, then
     let item = if let Ok(item) = Object::try_from(item) {
         // a. If item has an [[InitializedTemporalInstant]] or [[InitializedTemporalZonedDateTime]]
-        // internal slot, then TODO: TemporalZonedDateTime::try_from(item)
+        // internal slot, then
+        // TODO: TemporalZonedDateTime::try_from(item)
         if let Ok(item) = TemporalInstant::try_from(item) {
             // i. Return ! CreateTemporalInstant(item.[[EpochNanoseconds]]).
             return Ok(agent[item].instant);
         }
         // b. NOTE: This use of ToPrimitive allows Instant-like objects to be converted.
         // c. Set item to ? ToPrimitive(item, string).
-        to_primitive_object(agent, item.unbind(), Some(PreferredType::String), gc)?
+        to_primitive_object(
+            agent,
+            item.unbind(),
+            Some(PreferredType::String),
+            gc.reborrow(),
+        )
+        .unbind()?
+        .bind(gc.nogc())
     } else {
         Primitive::try_from(item).unwrap()
     };
     // 2. If item is not a String, throw a TypeError exception.
     let Ok(item) = String::try_from(item) else {
-        todo!() // TypeErrror
+        return Err(agent.throw_exception_with_static_message(
+            ExceptionType::TypeError,
+            "Item is not a String",
+            gc.into_nogc(),
+        ));
     };
     // 3. Let parsed be ? ParseISODateTime(item, « TemporalInstantString »).
     // 4. Assert: Either parsed.[[TimeZone]].[[OffsetString]] is not empty or
@@ -264,7 +277,8 @@ fn to_temporal_instant<'gc>(
     // 9. Let epochNanoseconds be GetUTCEpochNanoseconds(balanced).
     // 10. If IsValidEpochNanoseconds(epochNanoseconds) is false, throw a RangeError exception.
     // 11. Return ! CreateTemporalInstant(epochNanoseconds).
-    let parsed = temporal_rs::Instant::from_utf8(item.as_bytes(agent)).unwrap();
+    let parsed = temporal_rs::Instant::from_utf8(item.as_bytes(agent))
+        .map_err(|e| temporal_err_to_js_err(agent, e, gc.into_nogc()))?;
     Ok(parsed)
 }
 

nova_vm/src/ecmascript/builtins/temporal/instant/instant_constructor.rs

@@ -28,7 +28,6 @@ impl Builtin for TemporalInstantConstructor {
     const LENGTH: u8 = 1;
     const BEHAVIOUR: Behaviour = Behaviour::Constructor(TemporalInstantConstructor::constructor);
 }
-
 impl BuiltinIntrinsicConstructor for TemporalInstantConstructor {
     const INDEX: IntrinsicConstructorIndexes = IntrinsicConstructorIndexes::TemporalInstant;
 }
@@ -97,14 +96,13 @@ impl TemporalInstantConstructor {
             new_target = unsafe { scoped_new_target.take(agent) }.bind(gc.nogc());
             epoch_nanoseconds
         };
-
         // 3. If IsValidEpochNanoseconds(epochNanoseconds) is false, throw a RangeError exception.
         let Some(epoch_nanoseconds) = epoch_nanoseconds
             .try_into_i128(agent)
             .and_then(|nanoseconds| temporal_rs::Instant::try_new(nanoseconds).ok())
         else {
             return Err(agent.throw_exception_with_static_message(
-                ExceptionType::TypeError,
+                ExceptionType::RangeError,
                 "value out of range",
                 gc.into_nogc(),
             ));
@@ -214,7 +212,7 @@ impl TemporalInstantConstructor {
         mut gc: GcScope<'gc, '_>,
     ) -> JsResult<'gc, Value<'gc>> {
         let one = args.get(0).bind(gc.nogc());
-        let two = args.get(0).bind(gc.nogc());
+        let two = args.get(1).bind(gc.nogc());
         let two = two.scope(agent, gc.nogc());
         // 1. Set one to ? ToTemporalInstant(one).
         let one_instant = to_temporal_instant(agent, one.unbind(), gc.reborrow()).unbind()?;