Detect "system editor" at runtime on Linux #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squell
added
C-operatingsystem
squell
force-pushed
the
detect-editor
branch
2 times, most recently
from
124dfb1 to
8bc7a48
Compare
are obvious choices. Let's use a `Defaults editor` value that reflect this. (Making choices at compile-time instead of through configuration files is anachronistic in ogsudo as well.) On FreeBSD, "vi" comes with the base system so is the clear default.
squell
force-pushed
the
detect-editor
branch
from
8bc7a48 to
f019914
Compare
squell
force-pushed
the
detect-editor
branch
from
788eb87 to
7ac0718
Compare
see the comment in the test; it now tests what it purports to test for
bjorn3
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, there is no clearly established "default", but "nano" and "vi" are obvious choices.
On FreeBSD, "vi" comes with the base system so is the clear default