Check if stdio tty pgrp matches for exec_bg #1380
Open
+119
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
commented
Dec 9, 2025
Collaborator
Author
|
Pushed a commit to port sudo-project/sudo@78b7121 too. |
Member
|
I've created #1390 to remind us to write an integration test for the OFLAG commit that was piggy-backed on this PR. |
squell
approved these changes
Dec 15, 2025
Member
|
Note:I think the |
squell
approved these changes
Dec 15, 2025
Member
|
Maybe also an integration test that demonstrates the behaviour? |
bjorn3
force-pushed
the
tty_pgid_check
branch
from
82cd834 to
0e2dea0
Compare
This way redirecting stdio to another tty won't be treated as if stdio isn't redirected at all. This matches newer ogsudo versions.
exec_bg is already set and the only two other effects it has are calling disable_input() and changing a debug log message. The former is not necessary to do when stdout is a pipe to fix the missing keystroke issue while the latter now matches ogsudo.
bjorn3
force-pushed
the
tty_pgid_check
branch
from
0e2dea0 to
d6ed295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way redirecting stdio to another tty won't be treated as if stdio
isn't redirected at all.
This matches newer ogsudo versions.
Also introduced a
SafeTtytrait to ensure a bunch of methods that invoke ioctls only get called on known real ttys.Fixes #1377