Don't automatically enable tracing for fs feature#614
Don't automatically enable tracing for fs feature#614ginnyTheCat wants to merge 2 commits intotower-rs:mainfrom
Conversation
|
I'm a bit skeptical. I think people should get these error logs if they only enable the fs feature (I suppose we could make Also: |
I agree, but errors from other modules than the fs one already support running without tracing (and not getting these error logs). I have nothing against having tracing as a default feature though.
Building a http server using axum only pulls in tracing when using the tower-http fs feature or reqwest serverside (since hyper-utils's client feature still pulls it in) but client-legacy doesn't. |
2a59b49 to
2c2a565
Compare
Motivation
Currently the
"fs"features is exceptional in the way that it enables tracing even if the user didn't opt into this using the"tracing"feature.Solution
Make tracing opt-in for the
"fs"feature like it is for the other features as well.