Add html_as_default_extension option to ServeDir#519
Open
its-the-shrimp wants to merge 1 commit intotower-rs:mainfrom
Open
Add html_as_default_extension option to ServeDir#519its-the-shrimp wants to merge 1 commit intotower-rs:mainfrom
html_as_default_extension option to ServeDir#519its-the-shrimp wants to merge 1 commit intotower-rs:mainfrom
Conversation
This mirrors the common behaviour of file servers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It's common for file servers to add an
.htmlfile extension to the requested path if no file extension is provided, to allow for more concise & human-readable links, e.g. for a request of/dashboard, return/dashboard.htmlSolution
Add a
html_as_default_extensionoption to theServeDirservice, which will betrueby default, to be in tune withappend_index_html_on_directories