Skip to content

fixed prize format issue #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesmarquez wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fixed prize format issue #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions wp-content/themes/tcs-responsive/js/app/challenge-details/controllers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,15 @@ cdapp.controller('CDCtrl', ['$scope', 'ChallengeService', '$sce', function($scop
});

chglo = challenge;
//Bugfix refactored-challenge-details-40: format currency values with comma delimiters
if (typeof challenge.reliabilityBonus === 'number') {
challenge.reliabilityBonus = challenge.reliabilityBonus.format();
}
//loop over prizes and format number values
for (var i = 0; i < challenge.prize.length; i++) {
challenge.prize[i] = challenge.prize[i].format();
}

$scope.challenge = challenge;
$scope.reliabilityBonus = challenge.reliabilityBonus;
$scope.siteURL = siteURL;
Expand Down
11 changes: 11 additions & 0 deletions wp-content/themes/tcs-responsive/js/app/challenge-details/ng-challenge-detail-software.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,3 +562,14 @@ app.tabNavinit = function() {
}
})
}
//This function adds number formatting to JS number prototype
/**
* Number.prototype.format(n, x)
*
* @param integer n: length of decimal
* @param integer x: length of sections
*/
Number.prototype.format = function(n, x) {
var re = '\\d(?=(\\d{' + (x || 3) + '})+' + (n > 0 ? '\\.' : '$') + ')';
return this.toFixed(Math.max(0, ~~n)).replace(new RegExp(re, 'g'), '$&,');
};