PM-3200 switch away from using pgboss's worker #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import * as PgBoss from 'pg-boss'; | ||
| import { policies, Queue } from 'pg-boss'; | ||
|
|
||
| const PGBOSS_JOB_POLLING_INTERVAL = parseInt( |
There was a problem hiding this comment.
[correctness]
Consider validating the environment variable PGBOSS_JOB_POLLING_INTERVAL to ensure it is a positive integer. If the value is invalid, it could lead to unexpected behavior or errors.
kkartunov
approved these changes
Dec 10, 2025
| import * as PgBoss from 'pg-boss'; | ||
| import { policies, Queue } from 'pg-boss'; | ||
|
|
||
| const PGBOSS_JOB_POLLING_INTERVAL_SEC = parseFloat( |
There was a problem hiding this comment.
[💡 performance]
Consider using Number instead of parseFloat for converting environment variables to numbers. Number is generally more performant and sufficient for this use case, as it handles both integer and floating-point conversions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pgboss's workers don't seem to be fit with webhook actions & multiple tasks (issue with resolving promises when a webhook lands on a different task than it started on). So I switched to using manual fetching of jobs. This gives us more control, and calling job.fail or job.complete actually works (with workers it needed to fulfill the promise first).