Skip to content

fix(PM-2666): Reviews call doesn't triggered for submitters #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkartunov merged 2 commits into from
Dec 18, 2025
Merged

fix(PM-2666): Reviews call doesn't triggered for submitters #1387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e39fbb
fix: reviews are not fetched for submitters
hentrymartin Dec 16, 2025
31d9898
fix: lint
hentrymartin Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/apps/review/src/lib/hooks/useFetchScreeningReview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,11 +701,11 @@ export function useFetchScreeningReview(): useFetchScreeningReviewProps {
error: fetchChallengeReviewsError,
isValidating: isValidatingChallengeReviews,
}: SWRResponse<BackendReview[], Error> = useSWR<BackendReview[], Error>(
`reviewBaseUrl/reviews/${challengeId}/${reviewerKey}`,
challengeId && (reviewerIds.length || shouldForceReviewFetch)
Copy link

@github-actions github-actions bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The change from using isPaused to conditionally setting the SWR key to undefined is a good approach to prevent unnecessary API calls. However, ensure that challengeId and reviewerIds are always correctly initialized before this point to avoid potential issues with undefined values.

? `reviewBaseUrl/reviews/${challengeId}/${reviewerKey}`
: undefined,
{
fetcher: () => fetchChallengeReviews(challengeId ?? ''),
isPaused: () => !challengeId
|| (!reviewerIds.length && !shouldForceReviewFetch),
},
)

Expand Down
Loading