Merge pull request #1364 from topcoder-platform/pm-2662_1

fix(PM-2662): hide other submitters submissions if challenge is configured to hide it

Author: hentrymartin

src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentSubmissions.tsx

@@ -25,14 +25,15 @@ import {
     BackendSubmission,
     ChallengeDetailContextModel,
     convertBackendSubmissionToSubmissionInfo,
+    ReviewAppContextModel,
     SubmissionInfo,
 } from '../../models'
 import { TableNoRecord } from '../TableNoRecord'
 import { TableWrapper } from '../TableWrapper'
 import { SubmissionHistoryModal } from '../SubmissionHistoryModal'
 import { useSubmissionDownloadAccess } from '../../hooks/useSubmissionDownloadAccess'
 import type { UseSubmissionDownloadAccessResult } from '../../hooks/useSubmissionDownloadAccess'
-import { ChallengeDetailContext } from '../../contexts'
+import { ChallengeDetailContext, ReviewAppContext } from '../../contexts'
 import {
     challengeHasSubmissionLimit,
     getSubmissionHistoryKey,
@@ -42,6 +43,7 @@ import {
 import type { SubmissionHistoryPartition } from '../../utils'
 import { TABLE_DATE_FORMAT } from '../../../config/index.config'
 import { CollapsibleAiReviewsRow } from '../CollapsibleAiReviewsRow'
+import { useRolePermissions, UseRolePermissionsResult } from '../../hooks'
 
 import styles from './TabContentSubmissions.module.scss'
 
@@ -67,9 +69,36 @@ export const TabContentSubmissions: FC<Props> = props => {
         isSubmissionDownloadRestrictedForMember,
         getRestrictionMessageForMember,
     }: UseSubmissionDownloadAccessResult = useSubmissionDownloadAccess()
+    const { loginUserInfo }: ReviewAppContextModel = useContext(ReviewAppContext)
+    const { canViewAllSubmissions }: UseRolePermissionsResult = useRolePermissions()
 
     const { challengeInfo }: ChallengeDetailContextModel = useContext(ChallengeDetailContext)
 
+    const isCompletedDesignChallenge = useMemo(() => {
+        if (!challengeInfo) return false
+        const type = challengeInfo.track.name ? String(challengeInfo.track.name)
+            .toLowerCase() : ''
+        const status = challengeInfo.status ? String(challengeInfo.status)
+            .toLowerCase() : ''
+        return type === 'design' && (
+            status === 'completed'
+        )
+    }, [challengeInfo])
+
+    const isSubmissionsViewable = useMemo(() => {
+        if (!challengeInfo?.metadata?.length) return false
+        return challengeInfo.metadata.some(m => m.name === 'submissionsViewable' && String(m.value)
+            .toLowerCase() === 'true')
+    }, [challengeInfo])
+
+    const canViewSubmissions = useMemo(() => {
+        if (isCompletedDesignChallenge) {
+            return canViewAllSubmissions || isSubmissionsViewable
+        }
+
+        return true
+    }, [isCompletedDesignChallenge, isSubmissionsViewable, canViewAllSubmissions])
+
     const submissionMetaById = useMemo(
         () => {
             const map = new Map<string, BackendSubmission>()
@@ -205,19 +234,32 @@ export const TabContentSubmissions: FC<Props> = props => {
 
     const filteredSubmissions = useMemo<BackendSubmission[]>(
         () => {
+
+            const filterFunc = (submissions: BackendSubmission[]): BackendSubmission[] => submissions
+                .filter(submission => {
+                    if (!canViewSubmissions) {
+                        return String(submission.memberId) === String(loginUserInfo?.userId)
+                    }
+
+                    return true
+                })
+            const filteredByUserId = filterFunc(latestBackendSubmissions)
+            const filteredByUserIdSubmissions = filterFunc(props.submissions)
             if (restrictToLatest && hasLatestFlag) {
                 return latestBackendSubmissions.length
-                    ? latestBackendSubmissions
-                    : props.submissions
+                    ? filteredByUserId
+                    : filteredByUserIdSubmissions
             }
 
-            return props.submissions
+            return filteredByUserIdSubmissions
         },
         [
             latestBackendSubmissions,
             props.submissions,
             restrictToLatest,
             hasLatestFlag,
+            canViewSubmissions,
+            loginUserInfo?.userId,
         ],
     )
 

src/apps/review/src/lib/hooks/useRole.ts

@@ -24,6 +24,7 @@ export interface useRoleProps {
     hasReviewerRole: boolean
     hasApproverRole: boolean
     hasPostMortemReviewerRole: boolean
+    hasManagerRole: boolean
     checkpointScreenerResourceIds: Set<string>
     checkpointReviewerResourceIds: Set<string>
     copilotReviewerResourceIds: Set<string>
@@ -119,6 +120,18 @@ const useRole = (): useRoleProps => {
         [myResources],
     )
 
+    const pmResourceIds = useMemo<Set<string>>(
+        () => new Set(
+            (myResources ?? [])
+                .filter(resource => {
+                    const roleName = resource.roleName?.toLowerCase() ?? ''
+                    return roleName.includes('manager')
+                })
+                .map(resource => resource.id),
+        ),
+        [myResources],
+    )
+
     const screenerResourceIds = useMemo<Set<string>>(
         () => new Set(
             (myResources ?? [])
@@ -201,6 +214,11 @@ const useRole = (): useRoleProps => {
         [screenerResourceIds],
     )
 
+    const hasManagerRole = useMemo(
+        () => pmResourceIds.size > 0,
+        [pmResourceIds],
+    )
+
     const hasReviewerRole = useMemo(
         () => reviewerResourceIds.size > 0,
         [reviewerResourceIds],
@@ -235,6 +253,7 @@ const useRole = (): useRoleProps => {
         hasApproverRole,
         hasCheckpointReviewerRole,
         hasCheckpointScreenerRole,
+        hasManagerRole,
         hasPostMortemReviewerRole,
         hasReviewerRole,
         hasScreenerRole,

src/apps/review/src/lib/hooks/useRolePermissions.ts

@@ -18,10 +18,12 @@ import { useRole } from './useRole'
 export interface UseRolePermissionsResult {
     actionChallengeRole: ChallengeRole
     canManageCompletedReviews: boolean
+    canViewAllSubmissions: boolean
     hasCopilotRole: boolean
     hasReviewerRole: boolean
     hasSubmitterRole: boolean
     isAdmin: boolean
+    isProjectManager: boolean
     isCopilotWithReviewerAssignments: boolean
     ownedMemberIds: Set<string>
 }
@@ -38,6 +40,9 @@ export function useRolePermissions(): UseRolePermissionsResult {
     const {
         actionChallengeRole,
         hasReviewerRole,
+        hasApproverRole,
+        hasScreenerRole,
+        hasManagerRole,
         isCopilotWithReviewerAssignments,
     }: useRoleProps = useRole()
 
@@ -56,6 +61,18 @@ export function useRolePermissions(): UseRolePermissionsResult {
         [normalizedRoles],
     )
 
+    const isProjectManager = useMemo<boolean>(
+        () => (loginUserInfo?.roles?.some(
+            role => typeof role === 'string'
+                && role.toLowerCase() === UserRole.projectManager,
+        ) ?? false)
+            || normalizedRoles.some(role => role.includes('project manager')),
+        [
+            loginUserInfo?.roles,
+            normalizedRoles,
+        ],
+    )
+
     const isAdmin = useMemo<boolean>(
         () => (loginUserInfo?.roles?.some(
             role => typeof role === 'string'
@@ -82,14 +99,29 @@ export function useRolePermissions(): UseRolePermissionsResult {
         [hasCopilotRole, isAdmin],
     )
 
+    const canViewAllSubmissions = useMemo<boolean>(
+        () => (
+            isAdmin
+            || hasCopilotRole
+            || hasReviewerRole
+            || hasManagerRole
+            || hasScreenerRole
+            || hasApproverRole
+            || isProjectManager
+        ),
+        [hasCopilotRole, isAdmin, isProjectManager, hasReviewerRole, hasManagerRole, hasScreenerRole, hasApproverRole],
+    )
+
     return {
         actionChallengeRole,
         canManageCompletedReviews,
+        canViewAllSubmissions,
         hasCopilotRole,
         hasReviewerRole,
         hasSubmitterRole,
         isAdmin,
         isCopilotWithReviewerAssignments,
+        isProjectManager,
         ownedMemberIds,
     }
 }