Skip to content

Commit 985e16a

Browse files
authored
Merge pull request #1361 from topcoder-platform/pm-3141
fix(PM-3141): allow only admins and reviewer to respond to appeals
2 parents d7c673b + 0361d8c commit 985e16a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/apps/review/src/lib/components/Scorecard/ScorecardViewer/ScorecardQuestion/ReviewResponse/ReviewComment/ReviewComment.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { get, includes } from 'lodash'
1010
import { yupResolver } from '@hookform/resolvers/yup'
1111
import { IconAppeal, IconEdit } from '~/apps/review/src/lib/assets/icons'
1212
import { ADMIN, COPILOT, REVIEWER } from '~/apps/review/src/config/index.config'
13+
import { useRolePermissions, UseRolePermissionsResult } from '~/apps/review/src/lib/hooks'
1314

1415
import {
1516
AppealInfo,
@@ -44,6 +45,7 @@ const ReviewComment: FC<ReviewCommentProps> = props => {
4445
addAppeal,
4546
isSavingAppeal,
4647
}: ScorecardViewerContextValue = useScorecardViewerContext()
48+
const { isAdmin, hasReviewerRole }: UseRolePermissionsResult = useRolePermissions()
4749

4850
const { challengeInfo }: ChallengeDetailContextModel = useContext(
4951
ChallengeDetailContext,
@@ -175,7 +177,7 @@ const ReviewComment: FC<ReviewCommentProps> = props => {
175177
appeal={props.appeal}
176178
reviewItem={props.reviewItem}
177179
scorecardQuestion={props.question}
178-
canRespondToAppeal={isReviewerRole}
180+
canRespondToAppeal={isAdmin || hasReviewerRole}
179181
>
180182
{isSubmitter && canAddAppeal && (
181183
<div className={styles.blockBtns}>

src/apps/review/src/lib/components/TableAppealsResponse/TableAppealsResponse.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ export const TableAppealsResponse: FC<TableAppealsResponseProps> = (props: Table
107107
const canViewAsReviewer = hasReviewerRole
108108
const canViewAsSubmitter = hasSubmitterRole
109109
const canRender = canViewAllAppeals || canViewAsReviewer || canViewAsSubmitter
110-
const canRespondToAppeals = hasReviewerRole
110+
const canRespondToAppeals = hasReviewerRole || isAdmin
111111

112112
const isAppealsResponsePhaseOpen = useMemo<boolean>(
113113
() => (challengeInfo?.phases ?? []).some(phase => phase?.name?.toLowerCase() === 'appeals response'

0 commit comments

Comments
 (0)