Prod - fix for UUID group checking for new groups #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for returning UUID instead of OldID
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| */ | ||
| async getMemberGroups(memberId: string, dto: GetMemberGroupsDto) { | ||
| const returnUuid = dto.uuid; | ||
| const returnUuid = dto?.uuid ?? true; |
There was a problem hiding this comment.
[❗❗ correctness]
The use of the nullish coalescing operator (??) with dto?.uuid ?? true changes the behavior to default returnUuid to true if dto.uuid is null or undefined. Ensure this change is intentional and does not affect the logic where returnUuid should be false when dto.uuid is explicitly false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PS-453