Skip to content

Commit 468a48b

Browse files
author
Parth Shah
committed
Merge branch 'dev'
2 parents e221b58 + d0d50af commit 468a48b

File tree

6 files changed

+59
-33
lines changed

6 files changed

+59
-33
lines changed

src/projects/detail/components/FeatureSelector/DefaultFeatureForm.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ class DefaultFeatureForm extends Component {
6868
onChange={ this.toggleFeature }
6969
name="featue-active"
7070
checked={isActive}
71+
label="Enable feature"
7172
/>
7273
</div>
7374
<div className="feature-form-content">

src/projects/detail/components/FeatureSelector/FeatureForm.scss

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,17 @@
1212
background-color: $tc-gray-neutral-dark;
1313
}
1414
}
15-
15+
1616
.feature-title-row {
1717
display: flex;
1818
justify-content: space-between;
1919
margin-bottom: 4 * $base-unit;
2020
padding-bottom: 2 * $base-unit;
2121
border-bottom: 1px solid $tc-gray-10;
22-
22+
2323
.title {
2424
@include tc-heading;
2525
@include roboto-medium;
26-
2726
flex: 1;
2827
color: $tc-black;
2928
white-space: nowrap;
@@ -56,7 +55,6 @@
5655
}
5756

5857
.feature-form-content {
59-
6058
.feature-description {
6159
@include roboto;
6260
font-size: $tc-body-md;
@@ -65,10 +63,9 @@
6563
color: $tc-gray-50;
6664
margin: 4 * $base-unit 0px;
6765
}
68-
66+
6967
.predefined-feature-form,
7068
.custom-feature-form {
71-
7269
.feature-notes {
7370
label {
7471
@include tc-label-md;
@@ -102,7 +99,7 @@
10299
.feature-form-actions {
103100
display: flex;
104101
justify-content: center;
105-
102+
106103
button + button {
107104
margin-left: 4 * $base-unit;
108105
}
@@ -122,11 +119,30 @@
122119
}
123120
}
124121
}
125-
122+
126123
.description {
127124
textarea {
128125
margin-top: 64px;
129126
height: 150px;
130127
}
131128
}
132-
}
129+
130+
// Switch button extensions
131+
.SwitchButton {
132+
& > * {
133+
cursor: pointer;
134+
}
135+
136+
.label {
137+
transition: color 200ms ease-in-out;
138+
-moz-user-select: none;
139+
-webkit-user-select: none;
140+
-ms-user-select: none;
141+
user-select: none;
142+
}
143+
144+
&:hover .label {
145+
color: $tc-black;
146+
}
147+
}
148+
}

src/projects/detail/components/FeatureSelector/FeaturePicker.scss

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,23 @@
11
@import 'tc-includes';
2-
32
$card-max-width: 180px;
43
// Used to calculate the available height for the left-side column
54
$header-height: 60px;
65
$footer-height: 0;
76

8-
97
button {
108
&.clean {
119
background-color: transparent;
12-
border-radius : 0;
13-
border : none;
14-
padding : 0;
15-
margin : 0;
16-
font-size : inherit;
17-
font : inherit;
18-
line-height : inherit;
19-
font-weight : inherit;
20-
text-transform : inherit;
10+
border-radius: 0;
11+
border: none;
12+
padding: 0;
13+
margin: 0;
14+
font-size: inherit;
15+
font: inherit;
16+
line-height: inherit;
17+
font-weight: inherit;
18+
text-transform: inherit;
2119
}
20+
2221
&:active,
2322
&:focus {
2423
outline: none;
@@ -61,12 +60,13 @@ button {
6160
width: 320px;
6261
max-width: 320px;
6362
background-color: $tc-gray-10;
64-
border-right : 1px solid $tc-gray-20;
63+
border-right: 1px solid $tc-gray-20;
6564
position: relative;
65+
// Main container, scroll according to the content displayed inside.
66+
overflow-y: scroll;
67+
height: calc(100% - #{$header-height});
6668

6769
.feature-categories-list {
68-
overflow-y: scroll;
69-
max-height: calc(100% - #{$header-height}); //FIXME: ??
7070
width: 100%;
7171
padding: 4 * $base-unit 0;
7272

@@ -98,13 +98,14 @@ button {
9898
width: 100%;
9999
height: 100%;
100100
}
101-
}
101+
}
102102

103103
.features-content {
104104
max-width: 660px;
105105
width: 100%;
106106
position: relative;
107107
}
108+
108109
.feature-form-instructions {
109110
padding: 8 * $base-unit;
110111

src/projects/detail/components/FeatureSelector/FeaturePreview.scss

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,15 @@
22

33
.feature-preview {
44
text-align: center;
5-
/*padding: (8 * $base-unit) (12 * $base-unit) ;*/
6-
/*background: url('./images/Device-iPhone.svg') no-repeat;*/
7-
background-color: #FBFDFF;
5+
// padding: (8 * $base-unit) (12 * $base-unit) ;
6+
// background: url('./images/Device-iPhone.svg') no-repeat;
7+
background-color: #fbfdff;
88
background-position: 50% 22px;
99
padding: 8 * $base-unit;
1010
border-left: 1px solid $tc-dark-blue-30;
11+
min-width: 260px;
12+
display: block;
13+
1114
.feature-preview-img {
1215
background: url('./images/Device-iPhone.svg') no-repeat;
1316
/*padding: (8 * $base-unit) (12 * $base-unit) ;*/
@@ -16,6 +19,7 @@
1619
max-width: 273px;
1720
background-size: contain;
1821
}
22+
1923
img {
2024
display: inline-block;
2125
width: 100%;

src/projects/detail/containers/Specification.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,19 @@ $title-color: $tc-gray-80;
5050
.x-mark-icon {
5151
display: inline-block;
5252
margin: 0 0 0 5px;
53-
vertical-align: text-bottom;
5453
transition: all 200ms ease-in-out;
54+
55+
& > svg {
56+
padding-top: 3px;
57+
transition: all 200ms ease-in-out;
58+
}
5559
}
5660

5761
&:hover {
5862
color: $tc-black;
5963
cursor: pointer;
6064

61-
.x-mark-icon {
65+
.x-mark-icon > svg {
6266
fill: $tc-black;
6367
}
6468
}

src/projects/list/components/Projects/Projects.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ class Projects extends Component {
1515
}
1616

1717
componentDidUpdate() {
18-
window.scrollTo(0, parseInt(window.sessionStorage.getItem("projectsPageScrollTop")));
18+
window.scrollTo(0, parseInt(window.sessionStorage.getItem('projectsPageScrollTop')))
1919
}
2020

2121
componentWillUnmount(){
22-
const scrollingElement = document.scrollingElement || document.documentElement;
23-
window.sessionStorage.setItem('projectsPageScrollTop', scrollingElement.scrollTop);
22+
const scrollingElement = document.scrollingElement || document.documentElement
23+
window.sessionStorage.setItem('projectsPageScrollTop', scrollingElement.scrollTop)
2424
}
2525

2626
componentWillMount() {
@@ -45,7 +45,7 @@ class Projects extends Component {
4545
}
4646

4747
onPageChange(pageNum) {
48-
window.sessionStorage.removeItem('projectsPageScrollTop');
48+
window.sessionStorage.removeItem('projectsPageScrollTop')
4949
this.routeWithParams(this.props.criteria, pageNum)
5050
}
5151

0 commit comments

Comments
 (0)