Skip to content

Commit d0d50af

Browse files
author
Victor George
committed
Fix the feature picker list layout calculation/display
1 parent e796991 commit d0d50af

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

src/projects/detail/components/FeatureSelector/FeatureForm.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,11 @@
129129

130130
// Switch button extensions
131131
.SwitchButton {
132-
cursor: pointer;
132+
& > * {
133+
cursor: pointer;
134+
}
133135

134136
.label {
135-
cursor: pointer;
136137
transition: color 200ms ease-in-out;
137138
-moz-user-select: none;
138139
-webkit-user-select: none;

src/projects/detail/components/FeatureSelector/FeaturePicker.scss

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,23 @@
11
@import 'tc-includes';
2-
32
$card-max-width: 180px;
43
// Used to calculate the available height for the left-side column
54
$header-height: 60px;
65
$footer-height: 0;
76

8-
97
button {
108
&.clean {
119
background-color: transparent;
12-
border-radius : 0;
13-
border : none;
14-
padding : 0;
15-
margin : 0;
16-
font-size : inherit;
17-
font : inherit;
18-
line-height : inherit;
19-
font-weight : inherit;
20-
text-transform : inherit;
10+
border-radius: 0;
11+
border: none;
12+
padding: 0;
13+
margin: 0;
14+
font-size: inherit;
15+
font: inherit;
16+
line-height: inherit;
17+
font-weight: inherit;
18+
text-transform: inherit;
2119
}
20+
2221
&:active,
2322
&:focus {
2423
outline: none;
@@ -61,12 +60,13 @@ button {
6160
width: 320px;
6261
max-width: 320px;
6362
background-color: $tc-gray-10;
64-
border-right : 1px solid $tc-gray-20;
63+
border-right: 1px solid $tc-gray-20;
6564
position: relative;
65+
// Main container, scroll according to the content displayed inside.
66+
overflow-y: scroll;
67+
height: calc(100% - #{$header-height});
6668

6769
.feature-categories-list {
68-
overflow-y: scroll;
69-
max-height: calc(100% - #{$header-height}); //FIXME: ??
7070
width: 100%;
7171
padding: 4 * $base-unit 0;
7272

@@ -98,13 +98,14 @@ button {
9898
width: 100%;
9999
height: 100%;
100100
}
101-
}
101+
}
102102

103103
.features-content {
104104
max-width: 660px;
105105
width: 100%;
106106
position: relative;
107107
}
108+
108109
.feature-form-instructions {
109110
padding: 8 * $base-unit;
110111

0 commit comments

Comments
 (0)