Skip to content

Commit 329eb02

Browse files
committed
fix issue 4495
1 parent f41a005 commit 329eb02

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/projects/detail/components/SimplePlan/CreateSimplePlan/CreateSimplePlan.jsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import * as milestoneHelper from '../components/helpers/milestone'
1010

1111
import styles from './CreateSimplePlan.scss'
1212
import MilestonesApprovalNotification from '../components/MilestonesApprovalNotification'
13+
import { PHASE_STATUS_IN_REVIEW } from '../../../../../config/constants'
1314

1415
const createTabs = ({ onClick } ) => ([
1516
{
@@ -47,6 +48,10 @@ class CreateSimplePlan extends React.Component {
4748
} = this.props
4849
const onClickMilestonesTab = () => {}
4950

51+
const isUpdatable =
52+
isCustomer ? project.status === PHASE_STATUS_IN_REVIEW
53+
: isProjectLive
54+
5055
if (milestones.length === 0) {
5156
return isCustomer ? null : (
5257
<div styleName="add-new-milestone">
@@ -83,7 +88,7 @@ class CreateSimplePlan extends React.Component {
8388
onApproveMilestones={onApproveMilestones}
8489
projectMembers={project.members}
8590
project={project}
86-
isUpdatable={isProjectLive && !isCustomer}
91+
isUpdatable={isUpdatable}
8792
isCustomer={isCustomer}
8893
/>
8994
</div>

src/projects/detail/components/SimplePlan/ManageMilestones/ManageMilestones.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,13 +338,13 @@ class ManageMilestones extends React.Component {
338338
<col style={{ width: '11%' }} />{/* END DATE */}
339339
<col style={{ width: '10%' }} />{/* STATUS */}
340340
<col style={{ width: '13%' }} />{/* COPILOTS */}
341-
{(isUpdatable || isCustomer) && (<col style={{ width: '64px' }} />)}{/* ACTION */}
341+
{(isUpdatable) && (<col style={{ width: '64px' }} />)}{/* ACTION */}
342342
</colgroup>
343343
<thead>
344344
<MilestoneHeaderRow
345345
milestones={milestones}
346346
onChangeMilestones={onChangeMilestones}
347-
isUpdatable={isUpdatable || isCustomer}
347+
isUpdatable={isUpdatable}
348348
hideCheckbox={hideCheckbox}
349349
/>
350350
</thead>

0 commit comments

Comments
 (0)