Merge pull request #4508 from appirio-tech/hotfix/milestone-bug-fixes

elkhawajah · web-flow · commit f41a005c196d · 2021-09-25T21:46:37.000+04:00
[HOTFIX][DEV] Fixed bug in adding new milestone with null copilots
diff --git a/src/projects/detail/containers/DashboardContainer.jsx b/src/projects/detail/containers/DashboardContainer.jsx
@@ -216,7 +216,7 @@ class DashboardContainer extends React.Component {
       }
 
       const phaseMembers = getUpdatedPhaseMembers()
-      if(phaseMembers !== undefined) {
+      if(phaseMembers !== null) {
         productTemplate.members = phaseMembers.map(member => member.userId)
       }
 
@@ -248,15 +248,15 @@ class DashboardContainer extends React.Component {
       }
 
       const phaseMembers = getUpdatedPhaseMembers()
-      if(phaseMembers !== undefined) {
+      if(phaseMembers !== null) {
         updateParam.members = phaseMembers.map(member => member.userId)
       }
 
       updatePhase(
         phase.projectId,
         phase.id,
         updateParam
-      ).then(([{ action }]) => {
+      ).then(({ action }) => {
         const updatedCreateGameplanPhases = [...this.state.createGameplanPhases]
         const idx = updatedCreateGameplanPhases.findIndex(phase => phase.id === action.payload.id)
 

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ class DashboardContainer extends React.Component {`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`const phaseMembers = getUpdatedPhaseMembers()`
`219`		`- if(phaseMembers !== undefined) {`
	`219`	`+ if(phaseMembers !== null) {`
`220`	`220`	`productTemplate.members = phaseMembers.map(member => member.userId)`
`221`	`221`	`}`
`222`	`222`
`@@ -248,15 +248,15 @@ class DashboardContainer extends React.Component {`
`248`	`248`	`}`
`249`	`249`
`250`	`250`	`const phaseMembers = getUpdatedPhaseMembers()`
`251`		`- if(phaseMembers !== undefined) {`
	`251`	`+ if(phaseMembers !== null) {`
`252`	`252`	`updateParam.members = phaseMembers.map(member => member.userId)`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`updatePhase(`
`256`	`256`	`phase.projectId,`
`257`	`257`	`phase.id,`
`258`	`258`	`updateParam`
`259`		`- ).then(([{ action }]) => {`
	`259`	`+ ).then(({ action }) => {`
`260`	`260`	`const updatedCreateGameplanPhases = [...this.state.createGameplanPhases]`
`261`	`261`	`const idx = updatedCreateGameplanPhases.findIndex(phase => phase.id === action.payload.id)`
`262`	`262`