Only return review opps with available positions in listings

ThomasKranitsas · ThomasKranitsas · commit d6b3c111e871 · 2018-08-30T11:45:39.000+03:00
diff --git a/service/src/main/java/com/appirio/service/review/manager/ReviewOpportunitiesManager.java b/service/src/main/java/com/appirio/service/review/manager/ReviewOpportunitiesManager.java
@@ -265,7 +265,7 @@ public List<ReviewOpportunityItem> getReviewOpportunities(int challengeTypeId, Q
 
         if (challengeTypeId == 0) {
             // challengeTypeId is not provided in query string
-            queryParameter.setFilter(new FilterParameter(""));
+            queryParameter.setFilter(new FilterParameter("number_of_review_positions_available=>0"));
         } else {
             // if challengeTypeId is in query string
             // double check if its value is valid
@@ -274,7 +274,7 @@ public List<ReviewOpportunityItem> getReviewOpportunities(int challengeTypeId, Q
                     HttpServletResponse.SC_NOT_FOUND);
             }
 
-            queryParameter.setFilter(new FilterParameter("challenge_type_id=" + String.valueOf(challengeTypeId)));
+            queryParameter.setFilter(new FilterParameter("challenge_type_id=" + String.valueOf(challengeTypeId) + "&number_of_review_positions_available=>0"));
         }
 
         List<ReviewOpportunitiesDTO> revOpportunities = this.reviewOpportunitiesDAO.getReviewOpportunities(

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ public List<ReviewOpportunityItem> getReviewOpportunities(int challengeTypeId, Q`
`265`	`265`
`266`	`266`	`if (challengeTypeId == 0) {`
`267`	`267`	`// challengeTypeId is not provided in query string`
`268`		`- queryParameter.setFilter(new FilterParameter(""));`
	`268`	`+ queryParameter.setFilter(new FilterParameter("number_of_review_positions_available=>0"));`
`269`	`269`	`} else {`
`270`	`270`	`// if challengeTypeId is in query string`
`271`	`271`	`// double check if its value is valid`
`@@ -274,7 +274,7 @@ public List<ReviewOpportunityItem> getReviewOpportunities(int challengeTypeId, Q`
`274`	`274`	`HttpServletResponse.SC_NOT_FOUND);`
`275`	`275`	`}`
`276`	`276`
`277`		`- queryParameter.setFilter(new FilterParameter("challenge_type_id=" + String.valueOf(challengeTypeId)));`
	`277`	`+ queryParameter.setFilter(new FilterParameter("challenge_type_id=" + String.valueOf(challengeTypeId) + "&number_of_review_positions_available=>0"));`
`278`	`278`	`}`
`279`	`279`
`280`	`280`	`List<ReviewOpportunitiesDTO> revOpportunities = this.reviewOpportunitiesDAO.getReviewOpportunities(`