Rename submissionDeliverables to finalSubmissionGuidelines

ThomasKranitsas · ThomasKranitsas · commit bd3694b9f85d · 2018-08-30T00:03:25.000+03:00
diff --git a/service/src/main/java/com/appirio/service/review/api/ReviewOpportunitiesDTO.java b/service/src/main/java/com/appirio/service/review/api/ReviewOpportunitiesDTO.java
@@ -196,5 +196,5 @@ public class ReviewOpportunitiesDTO {
      */
     @Getter
     @Setter
-    private String submissionGuidelines;
+    private String finalSubmissionGuidelines;
 }
diff --git a/service/src/main/java/com/appirio/service/review/manager/ReviewOpportunitiesManager.java b/service/src/main/java/com/appirio/service/review/manager/ReviewOpportunitiesManager.java
@@ -815,7 +815,7 @@ private ReviewOpportunityItem convertReviewOpportunitiesDTO(ReviewOpportunitiesD
 
         if (returnDetailedRequirements) {
             challenge.put("detailedRequirements", dto.getDetailedRequirements());
-            challenge.put("submissionGuidelines", dto.getSubmissionGuidelines());
+            challenge.put("finalSubmissionGuidelines", dto.getFinalSubmissionGuidelines());
         }
         item.setChallenge(challenge);
 
diff --git a/service/src/main/resources/sql/review-opportunities/get-review-opportunities.sql b/service/src/main/resources/sql/review-opportunities/get-review-opportunities.sql
@@ -21,7 +21,7 @@ incremental_coefficient AS incrementalCoefficient,
 prize AS prize,
 submission_count AS submissionCount,
 detailed_requirements_text as detailedRequirements,
-final_submission_guidelines_text as submissionGuidelines
+final_submission_guidelines_text as finalSubmissionGuidelines
 FROM (
 SELECT
   ra.review_auction_id
diff --git a/service/src/test/resources/expected-sql/review-opportunities/review-opportunities-all-query.sql b/service/src/test/resources/expected-sql/review-opportunities/review-opportunities-all-query.sql
@@ -21,7 +21,7 @@ incremental_coefficient AS incrementalCoefficient,
 prize AS prize,
 submission_count AS submissionCount,
 detailed_requirements_text as detailedRequirements,
-final_submission_guidelines_text as submissionGuidelines
+final_submission_guidelines_text as finalSubmissionGuidelines
 FROM (
 SELECT
   ra.review_auction_id
diff --git a/service/src/test/resources/expected-sql/review-opportunities/review-opportunities-challenge-id-query.sql b/service/src/test/resources/expected-sql/review-opportunities/review-opportunities-challenge-id-query.sql
@@ -21,7 +21,7 @@ incremental_coefficient AS incrementalCoefficient,
 prize AS prize,
 submission_count AS submissionCount,
 detailed_requirements_text as detailedRequirements,
-final_submission_guidelines_text as submissionGuidelines
+final_submission_guidelines_text as finalSubmissionGuidelines
 FROM (
 SELECT
   ra.review_auction_id
diff --git a/service/src/test/resources/expected-sql/review-opportunities/review-opportunities-type-query.sql b/service/src/test/resources/expected-sql/review-opportunities/review-opportunities-type-query.sql
@@ -21,7 +21,7 @@ incremental_coefficient AS incrementalCoefficient,
 prize AS prize,
 submission_count AS submissionCount,
 detailed_requirements_text as detailedRequirements,
-final_submission_guidelines_text as submissionGuidelines
+final_submission_guidelines_text as finalSubmissionGuidelines
 FROM (
 SELECT
   ra.review_auction_id
diff --git a/swagger.yaml b/swagger.yaml
@@ -1103,7 +1103,7 @@ definitions:
           detailedRequirements:
             type: string
             description: the details requirement of the challenge
-          submissionGuidelines:
+          finalSubmissionGuidelines:
             type: string
             description: the submission deliverables of the challenge
           groupIds:

Original file line number	Diff line number	Diff line change
`@@ -196,5 +196,5 @@ public class ReviewOpportunitiesDTO {`
`196`	`196`	`*/`
`197`	`197`	`@Getter`
`198`	`198`	`@Setter`
`199`		`- private String submissionGuidelines;`
	`199`	`+ private String finalSubmissionGuidelines;`
`200`	`200`	`}`
Original file line number	Diff line number	Diff line change
`@@ -815,7 +815,7 @@ private ReviewOpportunityItem convertReviewOpportunitiesDTO(ReviewOpportunitiesD`
`815`	`815`
`816`	`816`	`if (returnDetailedRequirements) {`
`817`	`817`	`challenge.put("detailedRequirements", dto.getDetailedRequirements());`
`818`		`- challenge.put("submissionGuidelines", dto.getSubmissionGuidelines());`
	`818`	`+ challenge.put("finalSubmissionGuidelines", dto.getFinalSubmissionGuidelines());`
`819`	`819`	`}`
`820`	`820`	`item.setChallenge(challenge);`
`821`	`821`