[agent] Optimize BFV dot product accumulation #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ndarrayaccumulation indot_product_scalarwith a contiguousVec<u128>accumulator and explicit indexing to reduce iterator/Array2 overhead and improve cache locality.fmahelper, then reduce u128 accumulators to u64 via modulus operators and reconstructPolyparts.test_dot_product_scalar_step_byto validate strided/step_byiterator usage and ensure correctness for common MulPIR access patterns.expectcalls on slices with properResulterror returns when coefficient memory is not contiguous.Testing
cargo +nightly fmt --alland formatting completed successfully.cargo testand all unit tests and doc-tests passed (72+73tests in crates; overall test suites succeeded).cargo clippy --all-targets -- -D warningsand it completed without warnings.Codex Task