Create CNNS versioning scheme and improve dependency management#21
Open
adodon2go wants to merge 3 commits intotiswanso:vl3_latestfrom
adodon2go:versioning
Open
Create CNNS versioning scheme and improve dependency management#21adodon2go wants to merge 3 commits intotiswanso:vl3_latestfrom adodon2go:versioning
adodon2go wants to merge 3 commits intotiswanso:vl3_latestfrom
adodon2go:versioning
Conversation
Collaborator
adodon2go
commented
Jun 27, 2020
- Currently we build vl3 & vl3_kiknos images and publish them to Docker Hub:
- if CIRCLE_USERNAME is tiswanso it will publish under tiswanso user (@tiswanso you will need to add cnns-publish with DOCKER_USER and DOCKER_PASS for your Docker Hub account under your CircleCI project)
- otherwise it will publish under cnns user
- In case you do a git tag (on official or on your forked repo), vl3 & vl3_kiknos images will be published with the git tag (Ex: cnns/ucnf-kiknos-vppagent:vl3-v0.1.2 or cnns/vl3_ucnf-vl3-nse:vl3-v0.1.2)
- if CIRCLE_USERNAME is tiswanso images will be published with tag ${CIRCLE_BRANCH} (Ex: vl_latest, vl3_stable,etc)
- if CIRCLE_USERNAME is not tiswanso, images will be published with ${CIRCLE_SHA1} tag
- Updated CircleCI config to pass tests
Owner
|
IMO, we don't want to remove the e2e job. It's actually failing for a few reasons but the primary one is that the config lib is returning failures and the nse control binary is exiting. If I run the nse-binary manually (via in an ssh circleci session): I can morph this PR into what I'm thinking for labels as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.