✨ Fix optional types to return NULL when data unavailable (Claude provider) ✨ #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I ran the tests for the Claude provider specifically locally, and they passed. This PR fails on CI when re-rendering vignettes which require both Claude and OpenAI as I don't have an OpenAI API key so couldn't update the cassette locally. |
Contributor
Author
|
Converting to draft as it returns NULL in some cases where NA would be better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #899 - optional types (
required = FALSE) in structured data extraction would return explanatory text instead ofNULLwhen the requested information was not available in the conversation, when using Claude.It's >90% Claude but with lots of updated instructions from me to get to this version, and some tweaks.