Feature: Add offset option for scaling measurement values#52
Open
wilbersl wants to merge 4 commits intothin-edge:mainfrom
Open
Feature: Add offset option for scaling measurement values#52wilbersl wants to merge 4 commits intothin-edge:mainfrom
wilbersl wants to merge 4 commits intothin-edge:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additive scaling option (
offset) to register definitionDescription
This PR introduces an additional scaling option called
offsetto the register definition.The
offsetis applied after all existing multiplication-based scaling factors (multiplier,divisor,decimalShiftRight) have been processed.This enables linear value transformations of the form:
Motivation
Some registers cannot be represented correctly using multiplication-only scaling.
Typical use cases include:
-40°C)Adding
offsetallows these cases to be modeled cleanly while keeping the existing scaling model intact.Implementation Details
offsetfield to the register definitionoffsetafter all existing scaling operations0Backward Compatibility
offsetbehave exactly as beforeExample