Enable EL 8-9-10 support for libvirtd parameters#89
Draft
ikonia wants to merge 36 commits intothias:masterfrom
Draft
Enable EL 8-9-10 support for libvirtd parameters#89ikonia wants to merge 36 commits intothias:masterfrom
ikonia wants to merge 36 commits intothias:masterfrom
Conversation
Author
|
need to verify mdns parameters are breaking in later versions of libvirt as suggested in #81 testing suggests they will be ignored but need to verify better. Changed status to draft while verifying, feedback still waiting. Hope is to replace PR 81 and 82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change libvirtd.conf-el8.erb to actually be an erb file rather than a static text file.
Change default parameters to be set in the module where RHEL/Debian/Ubuntu align
put header on erb's to be clear this is a puppet managed resource
added new parameters that align to Debian 12 and RHEL 8 - 9 - 10
Sync templates between EL8 and other - allowing the removal of dual templates at a later date if this PR is accepted.