topology2: development: Enable SSP2 BT with echo reference support for sof-ptl-rt721-4ch.tplg #10458
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for SSP BT (Bluetooth) with echo reference capability to the sof-ptl-rt721-4ch topology configuration for Intel Panther Lake platform. The changes align with the kernel implementation referenced in the description.
Key Changes:
- Added new topology target
sof-ptl-rt721-4ch-bt-off-echoref.tplgwith BT offload support - Configured BT interface on SSP2 with PCM ID 20 and device ID 10
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # RT721 eval board with PCH-DMIC, sof_sdw_quirk_table with SOC_SDW_PCH_DMIC | ||
| # Enable echo reference capture from jack and speaker output | ||
| # Enable BT offload | ||
| "cavs-sdw\;sof-ptl-rt721-4ch-bt-off-echoref\;PLATFORM=ptl,SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,NUM_DMICS=4,\ |
There was a problem hiding this comment.
If you're enabling BT, why is it called bt-off?
There was a problem hiding this comment.
@ranj063 - renamed to sof-ptl-rt721-4ch-ssp2-bt-echoref.tplg
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-rt721-4ch-echoref.bin,DMIC0_ENHANCED_CAPTURE=true,\ | ||
| EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default,\ | ||
| DEEPBUFFER_FW_DMA_MS=10,DEEP_BUF_SPK=true,SDW_JACK_ECHO_REF=true,SDW_SPK_ECHO_REF=true" | ||
|
|
There was a problem hiding this comment.
please fix the prefix in the commit title to topology2: development: tplg-targets:....
Also, is the kernel patch link relevant in the commit message? Maybe you can add that in the PR description?
There was a problem hiding this comment.
@bardliao - missed this - done the change
| # RT721 eval board with PCH-DMIC, sof_sdw_quirk_table with SOC_SDW_PCH_DMIC | ||
| # Enable echo reference capture from jack and speaker output | ||
| # Enable BT offload | ||
| "cavs-sdw\;sof-ptl-rt721-4ch-bt-off-echoref\;PLATFORM=ptl,SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,NUM_DMICS=4,\ |
There was a problem hiding this comment.
@udaymb How will the tplg file be used? The kernel will not look for the sof-ptl-rt721-4ch-bt-off-echoref.tplg. Will you rename it to sof-ptl-rt721-4ch.tplg in the file system?
udaymb
force-pushed
the
alc721-ssp-bt-echo-ref
branch
from
2982875 to
3d4ea7a
Compare
udaymb
changed the title
udaymb
force-pushed
the
alc721-ssp-bt-echo-ref
branch
from
3d4ea7a to
f491ebd
Compare
udaymb
changed the title
…nce support for sof-ptl-rt721-4ch.tplg Support for SSP2 BT with echo reference is included in topology Topology name - sof-ptl-rt721-4ch-ssp2bt-echoref.tplg Signed-off-by: Uday M Bhat <uday.m.bhat@intel.com>
udaymb
force-pushed
the
alc721-ssp-bt-echo-ref
branch
from
f491ebd to
6d5b935
Compare
3 participants
SSP BT is supported for sof-ptl-rt721-4ch.tplg as implemented in the Linux kernel code
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/soc/intel/boards/sof_sdw.c?h=v6.18&id=7d0a66e4bb9081d75c82ec4957c50034cb0ea449#n767
Topology name - sof-ptl-rt721-4ch-ssp2-bt-echoref.tplg